Skip to content

treewide: fix typo chown -> chmod#347678

Merged
drupol merged 4 commits intoNixOS:masterfrom
r-vdp:chmod-chown
Oct 10, 2024
Merged

treewide: fix typo chown -> chmod#347678
drupol merged 4 commits intoNixOS:masterfrom
r-vdp:chmod-chown

Conversation

@r-vdp
Copy link
Copy Markdown
Contributor

@r-vdp r-vdp commented Oct 10, 2024

Things done

Fixes #347672

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Oct 10, 2024
@r-vdp
Copy link
Copy Markdown
Contributor Author

r-vdp commented Oct 10, 2024

@ofborg test nebula tmate-ssh-server

Copy link
Copy Markdown
Contributor

@drupol drupol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@drupol drupol merged commit a72a8bc into NixOS:master Oct 10, 2024
@r-vdp r-vdp deleted the chmod-chown branch October 10, 2024 08:58
@nixos-discourse
Copy link
Copy Markdown

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/breaking-changes-announcement-for-unstable/17574/63

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/`

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ec2-data: /etc/ssh owned by "755"

4 participants