Skip to content

fluxcd: 2.3.0 -> 2.4.0#345690

Merged
marcusramberg merged 4 commits intoNixOS:masterfrom
superherointj:package-fluxcd-2.4.0
Oct 9, 2024
Merged

fluxcd: 2.3.0 -> 2.4.0#345690
marcusramberg merged 4 commits intoNixOS:masterfrom
superherointj:package-fluxcd-2.4.0

Conversation

@superherointj
Copy link
Copy Markdown
Contributor

@superherointj superherointj commented Oct 1, 2024 •
edited
Loading

To test update script, delete information:

image

And execute: pkgs/by-name/fl/fluxcd/update.sh

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@superherointj superherointj changed the title fluxcd 2.3.0 -> 2.4.0 fluxcd: 2.3.0 -> 2.4.0 Oct 1, 2024
@superherointj superherointj mentioned this pull request Oct 1, 2024
Merged
10 tasks
@superherointj superherointj marked this pull request as draft October 1, 2024 11:59
@superherointj superherointj marked this pull request as ready for review October 1, 2024 12:06
@ofborg ofborg bot requested review from bryanasdev000 and jlesquembre October 1, 2024 12:40
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Oct 1, 2024
@superherointj
Copy link
Copy Markdown
Contributor Author

superherointj commented Oct 2, 2024

In case you don't mind reviewing. Application is good to go AFAIK.

CC @Aleksanaa @nbraud

@techknowlogick
Copy link
Copy Markdown
Member

techknowlogick commented Oct 4, 2024

Result of nixpkgs-review pr 345690 run on aarch64-darwin 1

1 package built:
  • fluxcd

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one person. label Oct 4, 2024
@superherointj
Copy link
Copy Markdown
Contributor Author

superherointj commented Oct 8, 2024

ping @marcusramberg

@marcusramberg
Copy link
Copy Markdown
Contributor

marcusramberg commented Oct 9, 2024

Result of nixpkgs-review pr 345690 run on aarch64-linux 1

1 package built:
  • fluxcd

@marcusramberg marcusramberg merged commit b755388 into NixOS:master Oct 9, 2024
@superherointj superherointj deleted the package-fluxcd-2.4.0 branch October 9, 2024 08:27
@superherointj
Copy link
Copy Markdown
Contributor Author

superherointj commented Oct 9, 2024

Thanks. Sorry for giving you extra work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bryanasdev000 bryanasdev000 Awaiting requested review from bryanasdev000

@jlesquembre jlesquembre Awaiting requested review from jlesquembre

1 more reviewer

@techknowlogick techknowlogick techknowlogick approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@superherointj @techknowlogick @marcusramberg @wegank