podman-desktop: 0.12.0 -> 1.13.2 by booxter · Pull Request #343648 · NixOS/nixpkgs

booxter · 2024-09-22T04:44:54Z

This also fixes a build failure on darwin due to read-only permissions on some Electron.app files, which apparently breaks electron-builder.

Closes: #343328

Description of changes

Bump the version to the latest release.
Sign the macos app with a hook.
Don't use desktopToDarwinBundle for Darwin.
Switched from yarn to pnpm.

Things done

Add a 👍 reaction to pull requests you find important.

panda2134

Looks good.

booxter · 2024-09-27T15:19:13Z

The passthru tests for linux fail with permission denied when building the Electron bundle too:

  ⨯ EACCES: permission denied, open '/build/source-patched/dist/linux-unpacked/podman-desktop'  failedTask=build stackTrace=Error: EACCES: permission denied, open '/build/source-patched/dist/linux-unpacked/podman-desktop'

I wonder if perhaps the "ugly hack" to fix it with chmod will have to be applied for all platforms.

khaneliman · 2024-09-29T18:45:25Z

`nixpkgs-review` result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 343648

`x86_64-linux`

❌ 1 package failed to build:

podman-desktop

khaneliman · 2024-09-29T18:47:17Z

For some reason, it's also not detecting a darwin rebuild.

khaneliman · 2024-09-29T18:49:56Z

   > mv: missing destination file operand after '/nix/store/mg2p3sanr09glbkc8r5l4yin3m810g77-podman-desktop-1.12.0/Applications'

x86-darwin ofborg error

booxter · 2024-10-03T20:55:38Z

Fixed mac x86 build (the directory is just dist/mac in this case). Applying chmod hack for linux, since it looks like the error is otherwise identical to darwin.

khaneliman · 2024-10-03T21:35:24Z

`nixpkgs-review` result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 343648

`x86_64-linux`

❌ 1 package failed to build:

podman-desktop

`aarch64-linux`

❌ 1 package failed to build:

podman-desktop

`x86_64-darwin`

✅ 1 package built:

podman-desktop

`aarch64-darwin`

✅ 1 package built:

podman-desktop

booxter · 2024-10-04T01:57:16Z

Both linux builds fail with:

Error: getaddrinfo EAI_AGAIN registry.npmjs.org
    at GetAddrInfoReqWrap.onlookupall [as oncomplete] (node:dns:120:26)
Emitted 'error' event on ClientRequest instance at:
    at emitErrorEvent (node:_http_client:108:11)
    at TLSSocket.socketErrorListener (node:_http_client:511:5)
    at TLSSocket.emit (node:events:519:28)
    at emitErrorNT (node:internal/streams/destroy:169:8)
    at emitErrorCloseNT (node:internal/streams/destroy:128:3)
    at process.processTicksAndRejections (node:internal/process/task_queues:82:21) {
  errno: -3001,
  code: 'EAI_AGAIN',
  syscall: 'getaddrinfo',
  hostname: 'registry.npmjs.org'
}

which I think is a sign that networking is sandboxed for these builders (but not for macos); so they probably fail to fetch something from npmjs registry to build the offline deps bundle. I am not sure how this is supposed to be tackled on packaging side. Any advice is welcome.

booxter · 2024-10-04T17:00:00Z

I don't understand how any package relying on prefetch-yarn-deps could ever build without DNS / fetching from NPM. Isn't it the whole point of the derivation - to fetch packages from registry (and then make sure that SHA is as expected)?

booxter · 2024-10-15T23:41:33Z

It's currently failing locally with

cp: cannot stat '/nix/store/8kfqm2hacl3s6zydjayw3lhk6p9gcx7v-electron-unwrapped-32.1.2/libexec/electron/Electron.app': No such file or directory

I will need to attend to this, though I still don't understand why DNS fails in ofborg. When I have a linux fix, we'll see if ofborg is any happier then.

This also fixes a build failure on darwin due to read-only permissions on some Electron.app files, which apparently breaks electron-builder. Closes: NixOS#343328

Also, add booxter to maintainers for podman-desktop.

This was fixed in podman-desktop 1.13.0 and is no longer needed.

khaneliman · 2024-10-16T15:46:09Z

`nixpkgs-review` result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 343648

`x86_64-linux`

✅ 1 package built:

podman-desktop

`aarch64-linux`

✅ 1 package built:

podman-desktop

khaneliman · 2024-10-16T15:49:16Z

Detecting no rebuild for darwin, for some reason. Going to manually build.

khaneliman · 2024-10-16T16:05:21Z

`nixpkgs-review` result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 343648

`x86_64-darwin`

✅ 1 package built:

podman-desktop

`aarch64-darwin`

✅ 1 package built:

podman-desktop

khaneliman

LGTM

booxter force-pushed the podman-desktop branch from 9b29bac to 8b644e4 Compare September 22, 2024 04:52

ofborg bot requested a review from panda2134 September 22, 2024 05:48

ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Sep 22, 2024

panda2134 approved these changes Sep 22, 2024

View reviewed changes

wegank added 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. labels Sep 22, 2024

booxter force-pushed the podman-desktop branch 3 times, most recently from 4792951 to 05bff7c Compare September 26, 2024 01:48

ofborg bot requested a review from panda2134 September 26, 2024 03:46

wegank removed the 12.approvals: 1 This PR was reviewed and approved by one person. label Sep 26, 2024

booxter force-pushed the podman-desktop branch from f813b12 to 8638d53 Compare October 16, 2024 00:49

podman-desktop: 0.12.0 -> 1.12.0

1b89990

This also fixes a build failure on darwin due to read-only permissions on some Electron.app files, which apparently breaks electron-builder. Closes: NixOS#343328

booxter force-pushed the podman-desktop branch from 8638d53 to 1b89990 Compare October 16, 2024 00:50

booxter changed the title ~~podman-desktop: 0.12.0 -> 1.12.0~~ podman-desktop: 0.12.0 -> 1.13.2 Oct 16, 2024

github-actions bot added the 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` label Oct 16, 2024

Ihar Hrachyshka added 2 commits October 16, 2024 02:48

podman-desktop: 0.12.0 -> 1.13.2

d4e06dd

maintainers: add booxter

9f7fc2b

Also, add booxter to maintainers for podman-desktop.

booxter force-pushed the podman-desktop branch from 024be31 to 9f7fc2b Compare October 16, 2024 02:49

booxter added 3 commits October 15, 2024 23:28

podman-desktop: don't disable signing for electron config

2ec2f2a

This was fixed in podman-desktop 1.13.0 and is no longer needed.

podman-desktop: use --replace-fail instead of --replace

c1afccd

podman-desktop: remove xcrun dependency

af71af6

booxter force-pushed the podman-desktop branch from 6299dcf to af71af6 Compare October 16, 2024 03:30

ofborg bot added the 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. label Oct 16, 2024

khaneliman approved these changes Oct 16, 2024

View reviewed changes

Artturin merged commit 8017b96 into NixOS:master Oct 19, 2024

Scrumplex mentioned this pull request Oct 19, 2024

pnpm: 9.12.1 -> 9.12.2 #349093

Merged

13 tasks

gepbird mentioned this pull request Oct 19, 2024

Update request: podman-desktop 0.12.0 → 0.13.0 #224301

Closed

1 task

kachick mentioned this pull request Oct 20, 2024

Install podman-desktop on darwin with nixpkgs kachick/dotfiles#862

Closed

kachick mentioned this pull request Dec 24, 2024

Podman-desktop stays in "initalizing" after starting on Gnome 45 and NixOS podman-desktop/podman-desktop#6339

Closed

booxter mentioned this pull request Jan 28, 2025

Another call for Darwin maintainers #323144

Open

Uh oh!

Conversation

booxter commented Sep 22, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description of changes

Things done

Uh oh!

panda2134 left a comment

Choose a reason for hiding this comment

Uh oh!

booxter commented Sep 27, 2024

Uh oh!

khaneliman commented Sep 29, 2024

nixpkgs-review result

x86_64-linux

Uh oh!

khaneliman commented Sep 29, 2024

Uh oh!

khaneliman commented Sep 29, 2024

Uh oh!

booxter commented Oct 3, 2024

Uh oh!

khaneliman commented Oct 3, 2024

nixpkgs-review result

x86_64-linux

aarch64-linux

x86_64-darwin

aarch64-darwin

Uh oh!

booxter commented Oct 4, 2024

Uh oh!

booxter commented Oct 4, 2024

Uh oh!

booxter commented Oct 15, 2024

Uh oh!

khaneliman commented Oct 16, 2024

nixpkgs-review result

x86_64-linux

aarch64-linux

Uh oh!

khaneliman commented Oct 16, 2024

Uh oh!

khaneliman commented Oct 16, 2024

nixpkgs-review result

x86_64-darwin

aarch64-darwin

Uh oh!

khaneliman left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

booxter commented Sep 22, 2024 •

edited

Loading

`nixpkgs-review` result

`x86_64-linux`

`nixpkgs-review` result

`x86_64-linux`

`aarch64-linux`

`x86_64-darwin`

`aarch64-darwin`

`nixpkgs-review` result

`x86_64-linux`

`aarch64-linux`

`nixpkgs-review` result

`x86_64-darwin`

`aarch64-darwin`