lib: Platform attribute cleanup#34315
Merged
Ericson2314 merged 2 commits intoNixOS:masterfrom Jan 27, 2018
Merged
Conversation
They still have `parsed.cpu.significantByte` which has the same info.
We compute it on the fly, careful to avoid any mass rebuilds for now.
Member
Author
|
@teto the openssl changes here are a is good example of the sort of change that should be done for the Linux kernel. |
6 tasks
Member
|
I know already merged, but LGTM and tested to work well in my tree as well! Thanks for these cleanups! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Progress towards #34274
Things done
No native hashes should be changed. Only cross openssl's hash should be changed.
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)