Skip to content

lib, glibc: Get rid of withTLS#34303

Merged
dezgeg merged 1 commit intoNixOS:masterfrom
obsidiansystems:glibc-always-tls
Jan 26, 2018
Merged

lib, glibc: Get rid of withTLS#34303
dezgeg merged 1 commit intoNixOS:masterfrom
obsidiansystems:glibc-always-tls

Conversation

@Ericson2314
Copy link
Copy Markdown
Member

@Ericson2314 Ericson2314 commented Jan 26, 2018 •
edited
Loading

glibc removed the underlying flag in 2011 in 83cd14204559abbb52635006832eaf4d2f42514a 1.

This gets us one step closer to fixing #34274: the cross stdenv for aarch64-unknown-linux-gnu at least evals now.

Thanks to @dezgeg for doing all the research for this.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@Ericson2314 Ericson2314 added the 6.topic: cross-compilation Building packages on a different platform than they will be used on label Jan 26, 2018
@Ericson2314 Ericson2314 requested a review from nbp as a code owner January 26, 2018 19:07
@GrahamcOfBorg GrahamcOfBorg added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Jan 26, 2018
dezgeg
dezgeg reviewed Jan 26, 2018
View reviewed changes
pkgs/development/libraries/glibc/common.nix Outdated
Copy link
Copy Markdown
Contributor

@dezgeg dezgeg Jan 26, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is unused now as well.

Copy link
Copy Markdown
Member Author

@Ericson2314 Ericson2314 Jan 26, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh figured as much and was going to try to make this not a cross mass rebuild, but it is already. Good catch.

@Ericson2314
lib, glibc: Get rid of withTLS
8a20c0e 
glibc removed the underlying flag in 2011 in
83cd14204559abbb52635006832eaf4d2f42514a [1].

This gets us one step closer to fixing NixOS#34274: the cross stdenv for
aarch64-unknown-linux-gnu at least evals now.

Thanks to @dezgeg for doing all the research for this.

[1]: https://sourceware.org/git/?p=glibc.git;a=commit;h=83cd14204559abbb52635006832eaf4d2f42514a
@dezgeg dezgeg merged commit 71f814a into NixOS:master Jan 26, 2018
@Ericson2314 Ericson2314 deleted the glibc-always-tls branch January 26, 2018 22:28
@Ericson2314 Ericson2314 mentioned this pull request Jan 27, 2018
Open
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nbp nbp Awaiting requested review from nbp

1 more reviewer

@dezgeg dezgeg dezgeg left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@dezgeg dezgeg

Labels

6.topic: cross-compilation Building packages on a different platform than they will be used on 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Ericson2314 @dezgeg @GrahamcOfBorg