Merged
Conversation
corngood
reviewed
Sep 12, 2024
Contributor
There was a problem hiding this comment.
IMO this functional change should be in a separate commit.
Member
Author
There was a problem hiding this comment.
It's a simple change with no chance to break anything so I simply added it to the commit msg.
Contributor
There was a problem hiding this comment.
so I simply added it to the commit msg.
The commit message's subject is oddly split across two lines for me with the &.
8b2b554 to
214f97e
Compare
wolfgangwalther
approved these changes
Sep 12, 2024
Contributor
There was a problem hiding this comment.
so I simply added it to the commit msg.
The commit message's subject is oddly split across two lines for me with the &.
214f97e to
3a8acca
Compare
…w common bash style There seems to be duplication and also improvements to one between these, so someone should rework these. Add missing `pre` and `post` hook runs.
3a8acca to
a0c0606
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.