Conversation
|
@ofborg test ec2-nixops |
|
https://logs.ofborg.org/?key=nixos/nixpkgs.340489&attempt_id=708d5437-709b-43b5-9e41-f3c56c38bceb @ofborg test ec2-nixops |
|
I will try to take a look later today, I think it also worked for me locally when I made this commit (several months ago, things might have changed on master in the meantime). I used to have some machines on AWS, which is why I ran into this in the first place, but I have since moved to another platform. |
I believe this plugin was also recently removed: #343727 |
|
Ok. no. this was just the aws plugin. |
|
@ofborg test ec2-nixops |
|
This test also fails on master for me when building it locally, I couldn't get it to work. |
pbsds
left a comment
There was a problem hiding this comment.
able to reproduce the issue.
I checked with the shellcheck rationale, diff LGTM!
|
Urgh this actually broke SSH access for our AWS images. I wish I was tagged for review on this. I would've tested it. I am marked as maintainer for |
|
I will try to allocate some time to write / fix a NixOS test that would've made this a channel blocker |
|
Thank you for following this up. Consider adding yourself to CODEOWNERS as well to ensure the ping, since nixos PRs commonly don't ping |
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/breaking-changes-announcement-for-unstable/17574/63 |
|
I'm trying to retro why this ever made it past a channel bump and I don't understand why. When it got merged I would expect the test to have failed on Hydra and block the channel. Why did this not happen? |
|
Ah because it's not in the |
This is more accurate. People dismissed failures in the past in this test because of the name. We don't want that. The test is important! It tests that SSH works! Hopefully this helps with #340489 (comment)
This is to catch issues like #340489 (comment) We do not want to push NixOS updates that break SSH access on EC2 instances.
This is more accurate. People dismissed failures in the past in this test because of the name. We don't want that. The test is important! It tests that SSH works! Hopefully this helps with NixOS#340489 (comment)
This is to catch issues like NixOS#340489 (comment) We do not want to push NixOS updates that break SSH access on EC2 instances.
Description of changes
Fix errors when enabling shellcheck on systemd service scripts (see #311394)
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.