Skip to content

Feature: [matrix-synapse] postgresql init#339977

Draft
luochen1990 wants to merge 4 commits intoNixOS:masterfrom
luochen1990:feat-matrix-synapse-postgresql-init
Draft

Feature: [matrix-synapse] postgresql init#339977
luochen1990 wants to merge 4 commits intoNixOS:masterfrom
luochen1990:feat-matrix-synapse-postgresql-init

Conversation

@luochen1990
Copy link
Copy Markdown
Contributor

@luochen1990 luochen1990 commented Sep 6, 2024 •
edited
Loading

Description of changes

Automatic init postgresql database and user for local pg instance.

This depends on

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Sep 6, 2024
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Sep 6, 2024
@luochen1990 luochen1990 marked this pull request as draft September 19, 2024 03:17
@Ma27
Copy link
Copy Markdown
Member

Ma27 commented Sep 20, 2024

The locale topic here was precisely the reason why the ensure* anti-pattern was removed from the synapse module.
See also #80447.

@luochen1990 luochen1990 mentioned this pull request Sep 21, 2024
Closed
10 tasks
@luochen1990
Copy link
Copy Markdown
Contributor Author

luochen1990 commented Sep 21, 2024

The locale topic here was precisely the reason why the ensure* anti-pattern was removed from the synapse module. See also #80447.

Thanks for your reply. I have give my opinion about "the ensure anti-pattern"* in #107342 (comment)

@wegank wegank added the 2.status: merge conflict This PR has merge conflicts with the target branch label Nov 1, 2024
@nixpkgs-ci nixpkgs-ci bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@thoughtpolice thoughtpolice Awaiting requested review from thoughtpolice

Assignees

No one assigned

Labels

2.status: merge conflict This PR has merge conflicts with the target branch 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@luochen1990 @Ma27 @wegank