Skip to content

mendeley: Re-link with qt 5.9#33864

Merged
adisbladis merged 1 commit intoNixOS:masterfrom
adisbladis:mendeley-qt59
Jan 15, 2018
Merged

mendeley: Re-link with qt 5.9#33864
adisbladis merged 1 commit intoNixOS:masterfrom
adisbladis:mendeley-qt59

Conversation

@adisbladis
Copy link
Copy Markdown
Member

@adisbladis adisbladis commented Jan 14, 2018

Motivation for this change

See #33798

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

As the application requires registration I have only tried to start it and it works.

cc @dtzWill

@adisbladis adisbladis mentioned this pull request Jan 14, 2018
25 tasks
@GrahamcOfBorg GrahamcOfBorg added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Jan 14, 2018
@dtzWill
Copy link
Copy Markdown
Member

dtzWill commented Jan 14, 2018

So I previously experienced either warnings or a graphical glitch when not attempting to match the Qt version they bundled.

I just tried this and it .. looks good to me?

I checked with LD_DEBUG=libs and /proc/$pid/maps -- no Qt 5.6 usage in sight! (I was worried my environment might have it around and that's why it "worked").

Glad we can move to 5.9, thanks for the PR!

@adisbladis
Copy link
Copy Markdown
Member Author

@dtzWill Thanks for testing this :)

@adisbladis adisbladis merged commit 554104e into NixOS:master Jan 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants