Skip to content

teamspeak_client: Re-link with qt 5.9#33863

Merged
adisbladis merged 1 commit intoNixOS:masterfrom
adisbladis:tsclient-qt59
Jan 23, 2018
Merged

teamspeak_client: Re-link with qt 5.9#33863
adisbladis merged 1 commit intoNixOS:masterfrom
adisbladis:tsclient-qt59

Conversation

@adisbladis
Copy link
Copy Markdown
Member

@adisbladis adisbladis commented Jan 14, 2018 •
edited
Loading

Motivation for this change

See #33798

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

Tested starting the application and clicking around the UI a bit and it seems to work fine.

cc @bkchr @DeltaEvo @nathanielbaxter

@adisbladis adisbladis mentioned this pull request Jan 14, 2018
Closed
25 tasks
@GrahamcOfBorg GrahamcOfBorg added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Jan 14, 2018
@adisbladis
Copy link
Copy Markdown
Member Author

adisbladis commented Jan 21, 2018

ping @bkchr @DeltaEvo @nathanielbaxter

@DeltaEvo
Copy link
Copy Markdown
Member

DeltaEvo commented Jan 21, 2018

Sorry I totally forgot this PR I will try it soon 👍

@bkchr
Copy link
Copy Markdown
Contributor

bkchr commented Jan 21, 2018

The commit works for me :) (with qt 5.10)

@DeltaEvo
Copy link
Copy Markdown
Member

DeltaEvo commented Jan 22, 2018

Works for me too 👍

@adisbladis adisbladis merged commit 62c5295 into NixOS:master Jan 23, 2018
@adisbladis
Copy link
Copy Markdown
Member Author

adisbladis commented Jan 23, 2018

Thanks for testing 👍

@nathanielbaxter
Copy link
Copy Markdown
Contributor

nathanielbaxter commented Jan 23, 2018 via email •
edited
Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@adisbladis @DeltaEvo @bkchr @nathanielbaxter @GrahamcOfBorg