Skip to content

Update grpc#337898

Closed
rorosen wants to merge 3 commits intoNixOS:stagingfrom
rorosen:update-grpc
Closed

Update grpc#337898
rorosen wants to merge 3 commits intoNixOS:stagingfrom
rorosen:update-grpc

Conversation

@rorosen
Copy link
Copy Markdown
Contributor

@rorosen rorosen commented Aug 28, 2024

Description of changes

This updates grpc and related python packages.

grpc: 1.62.1 -> 1.66.1

Diff: grpc/grpc@v1.62.1...v1.66.1

Changelog: https://github.com/grpc/grpc/releases/tag/v1.66.1

python3Packages.grpcio-status: 1.64.1 -> 1.66.0

python3Packages.grpcio-tools: 1.64.1 -> 1.66.0

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Aug 28, 2024
@rorosen rorosen requested review from LnL7 and mweinelt August 28, 2024 08:52
@ofborg ofborg bot requested a review from fabaff August 28, 2024 09:18
@ofborg ofborg bot added 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 501-1000 This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 501-1000 This PR causes many rebuilds on Linux and should normally target the staging branches. labels Aug 28, 2024
@nikstur
Copy link
Copy Markdown
Contributor

nikstur commented Aug 30, 2024

Should this target staging? @mweinelt

@risicle
Copy link
Copy Markdown
Contributor

risicle commented Sep 1, 2024

Addresses CVE-2024-7246

@risicle risicle added the 1.severity: security Issues which raise a security issue, or PRs that fix one label Sep 1, 2024
@risicle
Copy link
Copy Markdown
Contributor

risicle commented Sep 1, 2024 •
edited
Loading

Fails to build on macos 12 x86_64 though:

Undefined symbols for architecture x86_64:
  "_google__protobuf__EnumOptions_msg_init", referenced from:
      __upb_EnumDefs_New in enum_def.c.o
  "_google__protobuf__EnumValueOptions_msg_init", referenced from:
      __upb_EnumValueDefs_New in enum_value_def.c.o
  "_google__protobuf__ExtensionRangeOptions_msg_init", referenced from:
      __upb_ExtensionRanges_New in extension_range.c.o
  "_google__protobuf__FeatureSetDefaults_msg_init", referenced from:
      _upb_DefPool_SetFeatureSetDefaults in def_pool.c.o
  "_google__protobuf__FeatureSet_msg_init", referenced from:
      _upb_DefBuilder_AddFileToPool in def_pool.c.o
      __upb_FieldDef_Create in field_def.c.o
      __upb_DefBuilder_GetOrCreateFeatureSet in def_builder.c.o
      __upb_DefBuilder_DoResolveFeatures in def_builder.c.o
  "_google__protobuf__FieldOptions_msg_init", referenced from:
      __upb_FieldDef_Create in field_def.c.o
  "_google__protobuf__FileDescriptorProto_msg_init", referenced from:
      __upb_DefPool_LoadDefInitEx in def_pool.c.o
  "_google__protobuf__FileOptions_msg_init", referenced from:
      __upb_FileDef_Create in file_def.c.o
  "_google__protobuf__MessageOptions_msg_init", referenced from:
      __upb_MessageDefs_New in message_def.c.o
  "_google__protobuf__MethodOptions_msg_init", referenced from:
      __upb_MethodDefs_New in method_def.c.o
  "_google__protobuf__OneofOptions_msg_init", referenced from:
      __upb_OneofDefs_New in oneof_def.c.o
  "_google__protobuf__ServiceOptions_msg_init", referenced from:
      __upb_ServiceDefs_New in service_def.c.o
ld: symbol(s) not found for architecture x86_64

when building libupb_textformat_lib.43.0.0.dylib or libupb_json_lib.43.0.0.dylib

@risicle
Copy link
Copy Markdown
Contributor

risicle commented Sep 1, 2024

grpc/grpc#36654

@github-actions github-actions bot added 8.has: module (update) This PR changes an existing module in `nixos/` 6.topic: emacs Text editor 6.topic: policy discussion Discuss policies to work in and around Nixpkgs 6.topic: golang Go is a high-level general purpose programming language that is statically typed and compiled. 6.topic: ruby A dynamic, open source programming language with a focus on simplicity and productivity. 6.topic: fetch Fetchers (e.g. fetchgit, fetchsvn, ...) 6.topic: stdenv Standard environment 6.topic: nodejs Node.js is a free, open-source, cross-platform JavaScript runtime environment 6.topic: lua Lua is a powerful, efficient, lightweight, embeddable scripting language. 6.topic: lib The Nixpkgs function library 6.topic: zig Zig is an imperative, general-purpose, statically typed, compiled system programming language. 6.topic: php PHP is a general-purpose scripting language geared towards web development. labels Sep 1, 2024
@rorosen rorosen changed the base branch from master to staging September 1, 2024 19:04
@github-actions github-actions bot removed 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: qt/kde Object-oriented framework for GUI creation 8.has: documentation This PR adds or changes documentation 8.has: changelog This PR adds or changes release notes 8.has: module (update) This PR changes an existing module in `nixos/` 6.topic: emacs Text editor 6.topic: policy discussion Discuss policies to work in and around Nixpkgs 6.topic: golang Go is a high-level general purpose programming language that is statically typed and compiled. 6.topic: ruby A dynamic, open source programming language with a focus on simplicity and productivity. 6.topic: fetch Fetchers (e.g. fetchgit, fetchsvn, ...) 6.topic: stdenv Standard environment 6.topic: nodejs Node.js is a free, open-source, cross-platform JavaScript runtime environment 6.topic: lua Lua is a powerful, efficient, lightweight, embeddable scripting language. 6.topic: lib The Nixpkgs function library 6.topic: zig Zig is an imperative, general-purpose, statically typed, compiled system programming language. 6.topic: php PHP is a general-purpose scripting language geared towards web development. labels Sep 1, 2024
@K900
Copy link
Copy Markdown
Contributor

K900 commented Sep 1, 2024

Mass ping, please resubmit, and in the future draft your PRs before rebasing.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@mweinelt mweinelt Awaiting requested review from mweinelt

@LnL7 LnL7 Awaiting requested review from LnL7

@fabaff fabaff Awaiting requested review from fabaff

@figsoda figsoda Awaiting requested review from figsoda

@kalbasit kalbasit Awaiting requested review from kalbasit

@katexochen katexochen Awaiting requested review from katexochen

@Mic92 Mic92 Awaiting requested review from Mic92

@zowoq zowoq Awaiting requested review from zowoq

@jtojnar jtojnar Awaiting requested review from jtojnar

@aanderse aanderse Awaiting requested review from aanderse

@drupol drupol Awaiting requested review from drupol

@globin globin Awaiting requested review from globin

@Ma27 Ma27 Awaiting requested review from Ma27

@talyz talyz Awaiting requested review from talyz

@adisbladis adisbladis Awaiting requested review from adisbladis

@thoughtpolice thoughtpolice Awaiting requested review from thoughtpolice

@K900 K900 Awaiting requested review from K900

@NickCao NickCao Awaiting requested review from NickCao

@SuperSandro2000 SuperSandro2000 Awaiting requested review from SuperSandro2000

@ttuegel ttuegel Awaiting requested review from ttuegel

@ajs124 ajs124 Awaiting requested review from ajs124

@lukegb lukegb Awaiting requested review from lukegb

@stigtsp stigtsp Awaiting requested review from stigtsp

@zakame zakame Awaiting requested review from zakame

@marcusramberg marcusramberg Awaiting requested review from marcusramberg

@natsukium natsukium Awaiting requested review from natsukium

@Ericson2314 Ericson2314 Awaiting requested review from Ericson2314

@philiptaron philiptaron Awaiting requested review from philiptaron

@alyssais alyssais Awaiting requested review from alyssais

@infinisil infinisil Awaiting requested review from infinisil

Assignees

No one assigned

Labels

1.severity: security Issues which raise a security issue, or PRs that fix one 6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 501-1000 This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-linux: 501-1000 This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@rorosen @nikstur @risicle @K900