Skip to content

treewide: default.nix -> package.nix in pkgs/by-name#335636

Merged
pbsds merged 1 commit intoNixOS:masterfrom
pbsds:fix-by-name-update-scripts-1723996738
Aug 18, 2024
Merged

treewide: default.nix -> package.nix in pkgs/by-name#335636
pbsds merged 1 commit intoNixOS:masterfrom
pbsds:fix-by-name-update-scripts-1723996738

Conversation

@pbsds
Copy link
Copy Markdown
Member

@pbsds pbsds commented Aug 18, 2024

We need to remember to go over all the update scripts once the mass-by-name migration has happened

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

We need to remember to go over all the update scripts once the mass-by-name migration has happened
@pbsds pbsds marked this pull request as ready for review August 18, 2024 16:11
Copy link
Copy Markdown
Member

@Pandapip1 Pandapip1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Localsend diff LGTM

@Pandapip1 Pandapip1 added 12.approvals: 3+ This PR was reviewed and approved by three or more persons. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. labels Aug 18, 2024
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Aug 18, 2024
@pbsds pbsds merged commit 1e21ada into NixOS:master Aug 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. 12.approvals: 3+ This PR was reviewed and approved by three or more persons. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants