python311Packages.example-robot-data: fix strict deps#334270
Merged
wegank merged 1 commit intoNixOS:staging-nextfrom Aug 13, 2024
paparodeo:example-robot-data-strict-deps
Merged
python311Packages.example-robot-data: fix strict deps#334270wegank merged 1 commit intoNixOS:staging-nextfrom paparodeo:example-robot-data-strict-deps
wegank merged 1 commit intoNixOS:staging-nextfrom
paparodeo:example-robot-data-strict-deps
Conversation
add python to nativeBuildInputs to fix build
nim65s
approved these changes
Aug 13, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
add python to nativeBuildInputs to fix build
cmake strict deps was broken but #318226 fixed thus resulting in this build breakage because python is not available in nativeBuildInputs
cc @SomeoneSerge @emilazy @nim65s
propagating the nativeBuildInput python from eigenpy perhaps is a better option as noted by #334116 (comment) but is beyond my paygrade at the moment.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.