pkgs/top-level/aliases.nix: move llvmPackages_git back in#331880
Merged
tomberek merged 1 commit intoNixOS:masterfrom Aug 4, 2024
Merged
pkgs/top-level/aliases.nix: move llvmPackages_git back in#331880tomberek merged 1 commit intoNixOS:masterfrom
tomberek merged 1 commit intoNixOS:masterfrom
Conversation
13 tasks
Aleksanaa
reviewed
Aug 4, 2024
| linuxPackages_testing_bcachefs = throw "'linuxPackages_testing_bcachefs' has been removed, please use 'linuxPackages_latest', any kernel version at least 6.7, or any other linux kernel with bcachefs support"; | ||
| linux_testing_bcachefs = throw "'linux_testing_bcachefs' has been removed, please use 'linux_latest', any kernel version at least 6.7, or any other linux kernel with bcachefs support"; | ||
|
|
||
| llvmPackages_git = (recurseIntoAttrs (callPackages ../development/compilers/llvm { })).git; |
Member
There was a problem hiding this comment.
This means llvmPackages_git is now deprecated and will be removed after a certain period of time. Are you sure about that?
Also Please add Added YYYY-MM-DD to support automation.
Member
Author
There was a problem hiding this comment.
No, we will not be deprecating llvmPackages_git. Alyssa was just wanting it moved back into aliases.nix since the LLVM commonification moved it out of there.
tomberek
approved these changes
Aug 4, 2024
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
As requested by @alyssais, move
llvmPackages_gitout ofall-packages.nixand intoaliases.nixThings done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.