Skip to content

treewide: remove hardcoded /build#331855

Merged
Atemu merged 10 commits intoNixOS:stagingfrom
pbsds:fix-nix-build-top-1722623704
Aug 6, 2024
Merged

treewide: remove hardcoded /build#331855
Atemu merged 10 commits intoNixOS:stagingfrom
pbsds:fix-nix-build-top-1722623704

Conversation

@pbsds
Copy link
Copy Markdown
Member

@pbsds pbsds commented Aug 2, 2024

Description of changes

grepping for /build reveals a few demons, some of which i exorcise here

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Aug 2, 2024
@pbsds pbsds force-pushed the fix-nix-build-top-1722623704 branch from 5b40cdb to 268aa28 Compare August 2, 2024 21:46
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 1001-2500 This PR causes many rebuilds on Linux and should target the staging branches. labels Aug 2, 2024
@pbsds pbsds changed the base branch from master to staging August 3, 2024 01:05
@pbsds pbsds force-pushed the fix-nix-build-top-1722623704 branch from 268aa28 to 58df299 Compare August 3, 2024 01:36
@pbsds pbsds marked this pull request as ready for review August 3, 2024 01:36
@pbsds pbsds requested a review from mweinelt as a code owner August 3, 2024 01:36
Copy link
Copy Markdown
Contributor

@dasj19 dasj19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

Copy link
Copy Markdown
Member

@Atemu Atemu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Diff generally looks good to me.

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one person. label Aug 3, 2024
@Atemu Atemu merged commit c9dd3fb into NixOS:staging Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 1001-2500 This PR causes many rebuilds on Linux and should target the staging branches. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants