Skip to content

qsyncthingtray: build with native browser to allow for Qt > 5.6#33128

Merged
FRidh merged 1 commit intoNixOS:masterfrom
peterhoeg:u/qst
Feb 11, 2018
Merged

qsyncthingtray: build with native browser to allow for Qt > 5.6#33128
FRidh merged 1 commit intoNixOS:masterfrom
peterhoeg:u/qst

Conversation

@peterhoeg
Copy link
Copy Markdown
Member

@peterhoeg peterhoeg commented Dec 28, 2017

Motivation for this change

This means we can drop the Qt 5.6 dependency. I've been running with it here for some time without problems.

Cc: @zraexy

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg GrahamcOfBorg added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Dec 28, 2017
@adisbladis
Copy link
Copy Markdown
Member

adisbladis commented Dec 29, 2017 •
edited
Loading

@peterhoeg Is there a reason why you would want to build against Qt 5.6? I would like it if we could drop the Qt 5.6 dependency altogether.

@peterhoeg
Copy link
Copy Markdown
Member Author

peterhoeg commented Dec 30, 2017

This PR removes functionality so if someone desperately needs the built-in browser, they can build it against 5.6.

@adisbladis adisbladis mentioned this pull request Jan 12, 2018
Closed
25 tasks
@peterhoeg peterhoeg requested a review from FRidh January 13, 2018 06:11
@FRidh FRidh removed their request for review February 11, 2018 08:38
@FRidh FRidh merged commit d8b8c6b into NixOS:master Feb 11, 2018
@peterhoeg peterhoeg deleted the u/qst branch February 11, 2018 12:04
@peterhoeg peterhoeg restored the u/qst branch February 12, 2018 12:30
@peterhoeg peterhoeg deleted the u/qst branch March 5, 2018 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@peterhoeg @adisbladis @FRidh @GrahamcOfBorg