nixos/radicle: fix support of absolute file paths for SSH keys#329731
Merged
Mic92 merged 1 commit intoNixOS:masterfrom Jul 26, 2024
Merged
nixos/radicle: fix support of absolute file paths for SSH keys#329731Mic92 merged 1 commit intoNixOS:masterfrom
Mic92 merged 1 commit intoNixOS:masterfrom
Conversation
dpc
approved these changes
Jul 24, 2024
lorenzleutgeb
approved these changes
Jul 25, 2024
Contributor
Author
|
Oops, I should not have dropped the
$ ssh-keygen -t ed25519 -f radicle -N ""
$ systemd-creds encrypt --name radicle --with-key=auto radicle radicle.credAnd: services.radicle.privateKeyFile = "radicle:${path/to/radicle.cred}"Here the name of the credential appears as a prefix and thus |
14 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Following up on #314440 (comment)
Things done
privateKeyFileby droppingstrtype.publicKeyFileby usinglib.types.path.checkinstead ofbuiltins.isPath.publicKeyFiletopublicKeysince it supports bothpathandstrtypes. I've not cluttered the file with a backward compatibility becauseservices.radiclehas never been in a stable release yet.nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.