devShellTools: add environment functions#324789
Merged
Conversation
Member
Author
8355b09 to
2315aee
Compare
This was referenced Jul 5, 2024
Merged
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/4215 |
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/little-bites-of-nix-with-mise-seeking-design-feedback/48785/2 |
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/2024-07-08-nix-team-meeting-minutes/49099/1 |
tie
reviewed
Jul 19, 2024
Member
tie
left a comment
There was a problem hiding this comment.
Tested with nix build --file . tests.devShellTools and also nix build --file . nixosTests.docker-tools-nix-shell on aarch64-linux after adjusting it to build for all systems.
846e4df to
3c235f2
Compare
... and test it.
These tests should run as part of the `tests.devShellTools` suite, and they're a significant portion of the general docker tools test duration.
This removes redundant inline docs, because - users should consult the better docs in the manual, - contributors should add to the manual, not the inline comments
3c235f2 to
ae1cef4
Compare
The docker-tools test, where this originates, was not run on aarch64-linux, but this is an artifact of its age more so than anything else. Co-authored-by: Ivan Trubach <mr.trubach@icloud.com>
d9c740e to
1a70c80
Compare
|
Thank you, @roberth . |
20 tasks
Member
Author
|
13 tasks
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Moves the environment functions, adds tests, docs, and fixes.
See commit messages.
devShellTools#323398Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.