Regression test for libvirt NSS modules#323728
Conversation
This is a regression test for the implementation in 412543d which was fixed in NixOS#322022.
|
Oddly enough, this test never seems to pass for me. I tried running it and it's just running into (I'd investigate further but I don't have time at the moment, sorry!) |
ece2d80 to
90bb205
Compare
jchv
left a comment
There was a problem hiding this comment.
Pulled it again and now it works. nix build .#nixosTests.libvirtd succeeded.
|
@jchv Confirmed. Through hurry, this PR was based on the old master branch (before we added the fix). I rebased it on the up-to-date master. If you try again, the test will pass. Sorry for the extra roundtrip. At least we now proved the regression 😄 |
flokli
left a comment
There was a problem hiding this comment.
Tested this PR, both cherry-picked into master and hard-reset to the PR branch. Both succeed (on aarch64-linux).
Let's get this in!
This is a regression test for the implementation in 412543d which was fixed in #322022.
Description of changes
See source code comment.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.