Skip to content

radicle-node: 1.0.0-rc.10 → 1.0.0-rc.11#321299

Merged
JohnRTitor merged 1 commit intoNixOS:masterfrom
lorenzleutgeb:radicle
Jun 21, 2024
Merged

radicle-node: 1.0.0-rc.10 → 1.0.0-rc.11#321299
JohnRTitor merged 1 commit intoNixOS:masterfrom
lorenzleutgeb:radicle

Conversation

@lorenzleutgeb
Copy link
Copy Markdown
Member

@lorenzleutgeb lorenzleutgeb commented Jun 20, 2024

Description of changes

Release Notes on their Zulip.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@lorenzleutgeb lorenzleutgeb added 8.has: package (update) This PR updates a package to a newer version 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. labels Jun 20, 2024
@lorenzleutgeb lorenzleutgeb mentioned this pull request Jun 20, 2024
Merged
18 tasks
@ofborg ofborg bot requested a review from amesgen June 20, 2024 17:45
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Jun 20, 2024
@amesgen amesgen added 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. labels Jun 20, 2024
@gador
Copy link
Copy Markdown
Member

gador commented Jun 20, 2024

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).

Result of nixpkgs-review pr 321299 run on x86_64-linux 1

1 package built:
  • radicle-node

The following issues got detected with the above build packages.
Please fix at least the ones listed with your changed packages:

Details radicle-node:

got build log for '/nix/store/fl2n157yd6xrynj8jqymnnaaap40cw12-radicle-node-1.0.0-rc.11' from 'daemon'
When evaluating attribute ‘radicle-node’:
warning: environment-variables-go-to-env
Environment variable PKG_CONFIG_ALLOW_CROSS should be moved to env attribute rather than being passed directly to ‘stdenv.mkDerivation’.

Near pkgs/build-support/rust/build-rust-package/default.nix:135:3:

    |
135 |   PKG_CONFIG_ALLOW_CROSS =
    |   ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/environment-variables-go-to-env.md

@JohnRTitor
Copy link
Copy Markdown
Member

JohnRTitor commented Jun 21, 2024

Result of nixpkgs-review pr 321299 run on x86_64-linux 1

1 package built:
  • radicle-node

JohnRTitor
JohnRTitor approved these changes Jun 21, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@JohnRTitor JohnRTitor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JohnRTitor JohnRTitor merged commit 480f203 into NixOS:master Jun 21, 2024
@gador gador mentioned this pull request Jun 21, 2024
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JohnRTitor JohnRTitor JohnRTitor approved these changes

+1 more reviewer

@amesgen amesgen amesgen approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@amesgen amesgen

Labels

8.has: package (update) This PR updates a package to a newer version 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@lorenzleutgeb @gador @JohnRTitor @amesgen