Skip to content

xunit-viewer: init at 10.6.1#319020

Merged
roberth merged 2 commits intoNixOS:masterfrom
pluiedev:init/xunit-viewer
Jun 16, 2024
Merged

xunit-viewer: init at 10.6.1#319020
roberth merged 2 commits intoNixOS:masterfrom
pluiedev:init/xunit-viewer

Conversation

@pluiedev
Copy link
Copy Markdown
Member

@pluiedev pluiedev commented Jun 11, 2024

Description of changes

Fixes #318811

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

roberth
roberth approved these changes Jun 16, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@roberth roberth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

I've added tests to help automate part of the maintenance.

Just waiting for ofborg to eval now.

Thank you @pluiedev!

@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Jun 16, 2024
@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one person. label Jun 16, 2024
@roberth roberth mentioned this pull request Jun 16, 2024
Open
@roberth
Copy link
Copy Markdown
Member

roberth commented Jun 16, 2024

Also passes on aarch64-darwin.

@roberth roberth merged commit a94dfb6 into NixOS:master Jun 16, 2024
@roberth
Copy link
Copy Markdown
Member

roberth commented Jun 16, 2024

Thanks again @pluiedev!

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jun 16, 2024

Successfully created backport PR for release-24.05:

@github-actions github-actions bot mentioned this pull request Jun 16, 2024
Merged
1 task
@roberth roberth mentioned this pull request Jun 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@roberth roberth roberth approved these changes

Assignees

No one assigned

Labels

8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Package request: xunit-viewer

3 participants

@pluiedev @roberth @wegank