minio-exporter: remove#318841
Merged
SuperSandro2000 merged 2 commits intoNixOS:masterfrom Jun 25, 2024
Merged
Conversation
07698a2 to
7318a52
Compare
7318a52 to
8630124
Compare
35 tasks
bachp
approved these changes
Jun 11, 2024
Member
There was a problem hiding this comment.
I wonder if there is a way to enable this declaratively. But it seems it can only be done via mc admin command not via any form of config or environment variable.
Member
There was a problem hiding this comment.
I don't think that's worth the effort.
katexochen
previously requested changes
Jun 24, 2024
8630124 to
bc2c45c
Compare
bc2c45c to
50d911c
Compare
SuperSandro2000
approved these changes
Jun 25, 2024
50d911c to
43990c5
Compare
SuperSandro2000
approved these changes
Jun 25, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Please review this carefully, it is my first module deprecation.
Remove the minio-exporter module, as Minio has built-in Prometheus metrics for a while: https://min.io/docs/minio/linux/operations/monitoring/collect-minio-metrics-using-prometheus.html.
The minio-exporter package doesn't use Go modules, and can't be ported without rewriting of a lot of the source, as it has very outdated dependencies.
Related to #318069
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.