consul-alerts: migrate to buildGoModule#318257
Merged
katexochen merged 1 commit intoNixOS:masterfrom Jun 21, 2024
Merged
Conversation
Signed-off-by: Paul Meyer <49727155+katexochen@users.noreply.github.com>
35 tasks
Member
|
Not quite sure if we shouldn't just remove the package tbh. It nor it's forks hadn't seen updates in like 4 years. There aren't even issues in the last 2 years, so i guess the project can be considered pretty dead. |
Contributor
Author
Fine for me, too. Let's give @nh2 as package maintainer some time to react. |
Contributor
|
I replied in #320594 (comment) |
Contributor
Author
|
@nh2 let's go with this PR then, could you review if the change works for you? |
msanft
approved these changes
Jun 21, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Migrating to
buildGoModulesobuildGoPackagecan be deprecated.Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.