Use libXNVCtrl purely#318092
Merged
kira-bruneau merged 2 commits intoNixOS:masterfrom Jun 8, 2024
aidalgol:libxnvctrl-pure
Merged
Use libXNVCtrl purely#318092kira-bruneau merged 2 commits intoNixOS:masterfrom aidalgol:libxnvctrl-pure
kira-bruneau merged 2 commits intoNixOS:masterfrom
aidalgol:libxnvctrl-pure
Conversation
Put the path to libXNVCtrl on the RPATH of the MangoHUD binary.
kira-bruneau
approved these changes
Jun 7, 2024
Contributor
There was a problem hiding this comment.
Thanks @aidalgol! The change looks good to me - but I don't have an nvidia device to test this on right now.
kira-bruneau
reviewed
Jun 7, 2024
Kiskae
approved these changes
Jun 7, 2024
Contributor
Kiskae
left a comment
There was a problem hiding this comment.
Makes sense, it's an X extension with embedded version support, the client should check that the corresponding server has the support it requires.
kira-bruneau
approved these changes
Jun 8, 2024
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
libXNVCtrlis not tied to the Nvidia driver version, so we don't need to apply it via the NixOS optionhardware.opengl.extraPackages, and can instead let consumers of the library use it via the derivation directly.Closes #314289.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.