glib: Apply fix for memory issues#314043
Merged
jtojnar merged 1 commit intoNixOS:stagingfrom May 28, 2024
Merged
Conversation
See https://gitlab.gnome.org/GNOME/glib/-/merge_requests/4073 and related upstream issues for details.
This was referenced May 23, 2024
jtojnar
reviewed
May 23, 2024
Member
jtojnar
left a comment
There was a problem hiding this comment.
Looks good, thanks.
Should this perhaps be a release blocker?
1 task
Contributor
Author
Maybe? Without at least this, the Lomiri DE's shell & system settings are unbuildable: https://hydra.nixos.org/eval/1806508?filter=lomiri&compare=1806495 Next glib release that would ship this is planned after 24.05 release AFAICT, ~ 06.06.: https://gitlab.gnome.org/GNOME/glib/-/milestones/140 Don't know if anything else is affected by this. Linked issues indicate maybe mousepad, handbrake, libreoffice-qt. Haven't checked any of them yet though. |
This was referenced May 24, 2024
Contributor
|
Successfully created backport PR for |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
See https://gitlab.gnome.org/GNOME/glib/-/merge_requests/4073 and related upstream issues for details.
Fixes:
lomiri.lomiri-indicator-networktestslomiri.telephony-servicetestslomiri.telephony-servicesegfault innixosTests.ayatana-indicatorsThings done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.