Skip to content

bluemap: init at 3.21, and init module#312518

Merged
pbsds merged 2 commits intoNixOS:masterfrom
D4ndellion:bluemap
May 21, 2024
Merged

bluemap: init at 3.21, and init module#312518
pbsds merged 2 commits intoNixOS:masterfrom
D4ndellion:bluemap

Conversation

@D4ndellion
Copy link
Copy Markdown
Member

@D4ndellion D4ndellion commented May 17, 2024 •
edited
Loading

Description of changes

Bluemap is 3D minecraft map generator https://bluemap.bluecolored.de/

This PR adds the cli package and a module that properly configures rendering and serving the rendered files over nginx

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels May 17, 2024
@D4ndellion D4ndellion requested review from h7x4 and pbsds May 17, 2024 21:11
@D4ndellion D4ndellion force-pushed the bluemap branch 2 times, most recently from fa35511 to 74a99cb Compare May 17, 2024 21:25
@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels May 17, 2024
@D4ndellion D4ndellion force-pushed the bluemap branch 5 times, most recently from 682f334 to 0d56d76 Compare May 17, 2024 23:57
@D4ndellion D4ndellion marked this pull request as ready for review May 18, 2024 00:10
@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one person. label May 18, 2024
@D4ndellion D4ndellion marked this pull request as draft May 18, 2024 15:14
@D4ndellion D4ndellion marked this pull request as ready for review May 18, 2024 19:42
@pbsds
Copy link
Copy Markdown
Member

pbsds commented May 21, 2024

Could you add an entry to the release notes about the new module?

@D4ndellion
Copy link
Copy Markdown
Member Author

D4ndellion commented May 21, 2024

@pbsds done

@github-actions github-actions bot added 8.has: documentation This PR adds or changes documentation 8.has: changelog This PR adds or changes release notes labels May 21, 2024
@wegank wegank removed the 12.approvals: 1 This PR was reviewed and approved by one person. label May 21, 2024
@pbsds pbsds merged commit 64076ce into NixOS:master May 21, 2024
@philiptaron philiptaron mentioned this pull request Jun 21, 2024
Merged
13 tasks
@h7x4 h7x4 added the 8.has: module (new) This PR adds a module in `nixos/` label Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pbsds pbsds pbsds approved these changes

@h7x4 h7x4 Awaiting requested review from h7x4

Assignees

No one assigned

Labels

6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: changelog This PR adds or changes release notes 8.has: documentation This PR adds or changes documentation 8.has: module (new) This PR adds a module in `nixos/` 8.has: module (update) This PR changes an existing module in `nixos/` 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@D4ndellion @pbsds @wegank @h7x4