haskellPackages.cbor-tool: Unbroken#307818
Merged
maralorn merged 1 commit intoNixOS:haskell-updatesfrom Apr 29, 2024
Merged
Conversation
Contributor
Author
|
|
Member
This is funny, nearly the same PR twice. Yeah, updating that file would be great. Please see #307815 where I just left complete instructions. |
d358958 to
9644fc5
Compare
Contributor
Author
|
Heh, coworkers chatting on Slack but not being clear on who'd send the PR. Sorry for any extra noise there. 😅
|
Member
|
Still the wrong target branch. |
Fixed against GHC 9.8 in November: well-typed/cborg@f910b12
9644fc5 to
1e687bc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
cbor-toolbuilds again - it was fixed against more recent GHCs in November:well-typed/cborg@f910b12
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.