Skip to content

diagon: init at 1.1.158#297736

Open
petertrotman wants to merge 2 commits intoNixOS:masterfrom
petertrotman:Diagon
Open

diagon: init at 1.1.158#297736
petertrotman wants to merge 2 commits intoNixOS:masterfrom
petertrotman:Diagon

Conversation

@petertrotman
Copy link
Copy Markdown
Contributor

@petertrotman petertrotman commented Mar 21, 2024 •
edited
Loading

Added package for diagon and myself as maintainer.

https://github.com/ArthurSonzogni/Diagon

Diagon is an interactive interpreter. It transforms markdown-style expression into an ascii-art representation.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Mar 21, 2024
applePrincess
applePrincess suggested changes Mar 21, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@applePrincess applePrincess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also split commits into two:

  • adding yourself into maintainer list
  • ading diagon package

@applePrincess
Copy link
Copy Markdown
Contributor

applePrincess commented Mar 21, 2024

Result of nixpkgs-review pr 297736 run on x86_64-linux 1

1 package built:
  • diagon

@petertrotman
Copy link
Copy Markdown
Contributor Author

petertrotman commented Mar 21, 2024

Also split commits into two:

* adding yourself into maintainer list

* ading diagon package

Sure, done

@applePrincess
Copy link
Copy Markdown
Contributor

applePrincess commented Mar 22, 2024

Could you rebase this repo so that ff6a2e4 is not part of this PR.
Merge e4f0ee333a127a813380bc0e0f8d1db38acea720 and af7604394b2903e63a517d8499f4f796b71b0785 as a single commit diagon: init @ 1.1.158

@petertrotman
Copy link
Copy Markdown
Contributor Author

petertrotman commented Mar 22, 2024

Could you rebase this repo so that ff6a2e4 is not part of this PR. Merge e4f0ee3 and af76043 as a single commit diagon: init @ 1.1.158

Done and done.

@applePrincess
Copy link
Copy Markdown
Contributor

applePrincess commented Mar 23, 2024

Result of nixpkgs-review pr 297736 run on x86_64-linux 1

1 package built:
  • diagon

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one person. label Mar 23, 2024
@petertrotman
Copy link
Copy Markdown
Contributor Author

petertrotman commented Apr 24, 2024

Hi @applePrincess, I'm not sure what is supposed to happen with this. Would you please let me know what I need to do next to have this merged?

Thank you.

@applePrincess
Copy link
Copy Markdown
Contributor

applePrincess commented Apr 25, 2024

Not really. I do not have rights to merge so I can not make it happen but you can mention this PR on Discourse.

sikmir
sikmir reviewed Sep 13, 2024
View reviewed changes
sikmir
sikmir reviewed Sep 13, 2024
View reviewed changes
@wegank wegank added the 2.status: merge conflict This PR has merge conflicts with the target branch label Nov 1, 2024
@wegank wegank added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jan 2, 2025
@nixpkgs-ci nixpkgs-ci bot removed 2.status: merge conflict This PR has merge conflicts with the target branch 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md labels Nov 14, 2025
@sikmir sikmir changed the title diagon: init @ 1.1.158 diagon: init at 1.1.158 Nov 14, 2025
@sikmir
Copy link
Copy Markdown
Member

sikmir commented Nov 14, 2025

Please fix commit message.

@petertrotman petertrotman force-pushed the Diagon branch 2 times, most recently from 1b7aa19 to 7fcb6d2 Compare November 14, 2025 15:08
@nixpkgs-ci nixpkgs-ci bot added 2.status: merge conflict This PR has merge conflicts with the target branch and removed 2.status: merge conflict This PR has merge conflicts with the target branch labels Nov 14, 2025
@petertrotman petertrotman force-pushed the Diagon branch 3 times, most recently from 7bf5e55 to 95b20e6 Compare November 14, 2025 19:07
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` and removed 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. labels Nov 14, 2025
@sikmir
Copy link
Copy Markdown
Member

sikmir commented Nov 14, 2025

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 297736
Commit: b82e3f4fa45b6cb952b84f78e0d2374ee4411d5a (subsequent changes)
Merge: 198bd4252f91d242de37a63d3ebb53cd39c1d48b

Logs: https://github.com/sikmir/nixpkgs-review-gha/actions/runs/19377196419

x86_64-linux

❌ 1 package failed to build:
  • diagon

aarch64-linux

❌ 1 package failed to build:
  • diagon

x86_64-darwin (sandbox = true)

❌ 1 package failed to build:
  • diagon

aarch64-darwin (sandbox = true)

❌ 1 package failed to build:
  • diagon

@petertrotman petertrotman force-pushed the Diagon branch 4 times, most recently from 829ddc2 to 5409769 Compare November 15, 2025 09:47
@petertrotman petertrotman requested a review from sikmir November 15, 2025 20:47
@sikmir
Copy link
Copy Markdown
Member

sikmir commented Nov 16, 2025

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 297736
Commit: 54097699e896a1fbd8cc686f5bd021b0d59e0e1a (subsequent changes)
Merge: 68e9174cec0acea341b93763d8fd8637b31821f9

Logs: https://github.com/sikmir/nixpkgs-review-gha/actions/runs/19403580224

x86_64-linux

❌ 1 package failed to build:
  • diagon

aarch64-linux

❌ 1 package failed to build:
  • diagon

x86_64-darwin (sandbox = true)

❌ 1 package failed to build:
  • diagon

aarch64-darwin (sandbox = true)

❌ 1 package failed to build:
  • diagon

@petertrotman
Copy link
Copy Markdown
Contributor Author

petertrotman commented Nov 16, 2025

Hi @sikmir - do you have any idea why the source hash is different for you than for me? I have tested the build on another machine and it agrees with the hash that's in the commit here.

Thanks.

@sikmir
Copy link
Copy Markdown
Member

sikmir commented Nov 16, 2025

Hi @sikmir - do you have any idea why the source hash is different for you than for me? I have tested the build on another machine and it agrees with the hash that's in the commit here.

Thanks.

Why we need deepClone = true;?

@petertrotman
Copy link
Copy Markdown
Contributor Author

petertrotman commented Nov 16, 2025

@sikmir good catch, it was needed with a previous commit but I guess they removed their submodules in a version bump. I've updated the versions and removed the deepClone. Hopefully it will work now.

@sikmir
Copy link
Copy Markdown
Member

sikmir commented Nov 16, 2025

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 297736
Commit: dff059e25eee7aa958c606aeb6b5879ae1c674f0 (subsequent changes)
Merge: 17856c7ceac7d3c6ec116e011f5b995387166d12

Logs: https://github.com/sikmir/nixpkgs-review-gha/actions/runs/19406574272

x86_64-linux

✅ 1 package built:
  • diagon

aarch64-linux

✅ 1 package built:
  • diagon

x86_64-darwin (sandbox = true)

✅ 1 package built:
  • diagon

aarch64-darwin (sandbox = true)

✅ 1 package built:
  • diagon

@nixpkgs-ci nixpkgs-ci bot removed the 8.has: package (new) This PR adds a new package label Jan 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sikmir sikmir Awaiting requested review from sikmir

1 more reviewer

@applePrincess applePrincess applePrincess approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@petertrotman @applePrincess @sikmir @wegank