Skip to content

python311Packages.radios: 0.3.0 -> 0.3.1#295505

Merged
mweinelt merged 7 commits intoNixOS:staging-nextfrom
dotlambda:radios-0.3.1
Mar 13, 2024
Merged

python311Packages.radios: 0.3.0 -> 0.3.1#295505
mweinelt merged 7 commits intoNixOS:staging-nextfrom
dotlambda:radios-0.3.1

Conversation

@dotlambda
Copy link
Copy Markdown
Member

@dotlambda dotlambda commented Mar 13, 2024

Description of changes

Diff: frenck/python-radios@v0.3.0...v0.3.1

Changelog: https://github.com/frenck/python-radios/releases/tag/v0.3.1

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Mar 13, 2024
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 101-500 This PR causes between 101 and 500 packages to rebuild on Darwin. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 1001-2500 This PR causes many rebuilds on Linux and should target the staging branches. labels Mar 13, 2024
@dotlambda dotlambda changed the base branch from master to staging March 13, 2024 03:21
@ofborg ofborg bot added the 2.status: merge conflict This PR has merge conflicts with the target branch label Mar 13, 2024
@dotlambda dotlambda requested a review from mweinelt March 13, 2024 03:41
@dotlambda dotlambda changed the base branch from staging to staging-next March 13, 2024 03:46
@dotlambda
Copy link
Copy Markdown
Member Author

dotlambda commented Mar 13, 2024

@mweinelt Would you prefer I move the pycountry commit to staging?

@ofborg ofborg bot added 8.has: package (new) This PR adds a new package and removed 2.status: merge conflict This PR has merge conflicts with the target branch labels Mar 13, 2024
DamienCassou
DamienCassou approved these changes Mar 13, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@DamienCassou DamienCassou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand the rationale for some changes. Could the commit messages detail them a bit?

Also, is there any relationship between these commits?

pkgs/development/python-modules/xhtml2pdf/default.nix
src = fetchFromGitHub {
owner = pname;
repo = pname;
owner = "xhtml2pdf";
Copy link
Copy Markdown
Contributor

@DamienCassou DamienCassou Mar 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why changing that?

Copy link
Copy Markdown
Member

@mweinelt mweinelt Mar 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because semantically they're not the same thing.

Copy link
Copy Markdown
Member Author

@dotlambda dotlambda Mar 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#277994

pkgs/development/python-modules/woob/default.nix
pyyaml
requests
rich
termcolor
Copy link
Copy Markdown
Contributor

@DamienCassou DamienCassou Mar 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why removing these dependencies?

Copy link
Copy Markdown
Member

@mweinelt mweinelt Mar 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because we always miss things in the python-updates bulk update.

Copy link
Copy Markdown
Member Author

@dotlambda dotlambda Mar 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I searched the upstream code for the dependency and couldn't find it.

pkgs/development/python-modules/woob/default.nix
src = fetchFromGitLab {
owner = "woob";
repo = pname;
repo = "woob";
Copy link
Copy Markdown
Contributor

@DamienCassou DamienCassou Mar 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why changing that?

Copy link
Copy Markdown
Member Author

@dotlambda dotlambda Mar 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#277994

@delroth delroth added the 12.approvals: 1 This PR was reviewed and approved by one person. label Mar 13, 2024
@mweinelt
Copy link
Copy Markdown
Member

mweinelt commented Mar 13, 2024

@mweinelt Would you prefer I move the pycountry commit to staging?

Not really, we are still early enough in staging-next.

@mweinelt mweinelt merged commit 4ee0840 into NixOS:staging-next Mar 13, 2024
@dotlambda
Copy link
Copy Markdown
Member Author

dotlambda commented Mar 13, 2024

Also, is there any relationship between these commits?

They all came up as broken after trying to update pycountry.

@dotlambda dotlambda deleted the radios-0.3.1 branch March 13, 2024 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DamienCassou DamienCassou DamienCassou approved these changes

@mweinelt mweinelt Awaiting requested review from mweinelt

@zraexy zraexy Awaiting requested review from zraexy

@DeeUnderscore DeeUnderscore Awaiting requested review from DeeUnderscore

@dezgeg dezgeg Awaiting requested review from dezgeg

Assignees

No one assigned

Labels

6.topic: python Python is a high-level, general-purpose programming language. 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 101-500 This PR causes between 101 and 500 packages to rebuild on Darwin. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 1001-2500 This PR causes many rebuilds on Linux and should target the staging branches. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dotlambda @mweinelt @DamienCassou @delroth