nixos-option: update to nix 2.18#293542
Merged
mweinelt merged 1 commit intoNixOS:masterfrom Mar 5, 2024
Merged
Conversation
This utility has horrendous code quality, partially due to nix's fault, and really desperately needs to be rewritten, hopefully to not use the nix C++ API. Either use the Python bindings to the Nix C API when the Nix team merges the C API, or just write a clever bit of Nix script to extract the data from a config, turn it into json, then process it into good output in a CLI wrapper. It currently does not support flakes and has many other issues. (in my testing it did not accept -I nixos-path, it exploded due to having plugins in /etc/nix/nix.conf with no way to override that, among other breakage that simply does not exist in the Nix CLI).
RaitoBezarius
approved these changes
Mar 5, 2024
thufschmitt
approved these changes
Mar 5, 2024
Member
|
Result of 2 packages built:
|
mweinelt
approved these changes
Mar 5, 2024
Member
mweinelt
left a comment
There was a problem hiding this comment.
Build tested on aarch64-darwin, x86_64-darwin, aarch64-linux, x86_64-linux.
Runs, works, thank you.
Contributor
|
Successfully created backport PR for |
1 task
Contributor
|
Git push to origin failed for release-23.11 with exitcode 1 |
1 similar comment
Contributor
|
Git push to origin failed for release-23.11 with exitcode 1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This utility has horrendous code quality, partially due to nix's fault, and really desperately needs to be rewritten, hopefully to not use the nix C++ API. Either use the Python bindings to the Nix C API when the Nix team merges the C API, or just write a clever bit of Nix script to extract the data from a config, turn it into json, then process it into good output in a CLI wrapper.
It currently does not support flakes and has many other issues. (in my testing it did not accept -I nixos-path, it exploded due to having plugins in /etc/nix/nix.conf with
no way to override that(NIX_CONFIG??), among other breakage that simply does not exist in the Nix CLI).Description of changes
I basically grepped the nix sources for invocations of all the broken functions and then guessed how to adapt the code. I have tested it manually.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.