Skip to content

llvmPackages_git: 18.0.0-unstable-2023-10-04 -> 18.0.0-unstable-2023-12-13#286525

Merged
wegank merged 4 commits intoNixOS:masterfrom
wegank:llvm-git-bump
Feb 6, 2024
Merged

llvmPackages_git: 18.0.0-unstable-2023-10-04 -> 18.0.0-unstable-2023-12-13#286525
wegank merged 4 commits intoNixOS:masterfrom
wegank:llvm-git-bump

Conversation

@wegank
Copy link
Copy Markdown
Member

@wegank wegank commented Feb 5, 2024 •
edited
Loading

Description of changes

Extracted from #285786, but instead, bumps to the last commit before llvm/llvm-project@a4336f2, which looks very suspicious (see the "-DLIBCXX_ADDITIONAL_LIBRARIES=gcc_s" hack in that PR?)

Also closes #278667.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@wegank wegank requested a review from RaitoBezarius as a code owner February 5, 2024 16:29
@wegank
Copy link
Copy Markdown
Member Author

wegank commented Feb 5, 2024

@ofborg build llvmPackages_git

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Feb 5, 2024
@wegank
Copy link
Copy Markdown
Member Author

wegank commented Feb 5, 2024

llvmPackages_git.llvm passes on x86_64-darwin.

@wegank
Copy link
Copy Markdown
Member Author

wegank commented Feb 6, 2024 •
edited
Loading

llvmPackages_git.libcxx doesn't build starting from llvm/llvm-project@a4336f2, so this PR indeed pushes the package the furthest it can.

I guess I'll test pkgsCross / pkgsStatic via ofborg, since there already was no cache for llvmPackages_17, and building Clang on my slow machine takes at least 4 hours.

@wegank
Copy link
Copy Markdown
Member Author

wegank commented Feb 6, 2024

@ofborg build pkgsStatic.llvmPackages_git.clang

@wegank
Copy link
Copy Markdown
Member Author

wegank commented Feb 6, 2024 •
edited
Loading

@ofborg build pkgsCross.wasi32.llvmPackages_git.libcxx

@wegank
Copy link
Copy Markdown
Member Author

wegank commented Feb 6, 2024 •
edited
Loading

Both tests passed. Looks like I don't have to worry about pkgsStatic.llvmPackages_git.libcxx, since it already fails for llvmPackages_17? 😅

@wegank wegank merged commit c380de2 into NixOS:master Feb 6, 2024
@wegank wegank deleted the llvm-git-bump branch February 6, 2024 20:37
@rrbutani rrbutani added the 6.topic: llvm/clang Issues related to llvmPackages, clangStdenv and related label May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@RaitoBezarius RaitoBezarius Awaiting requested review from RaitoBezarius

Assignees

No one assigned

Labels

6.topic: llvm/clang Issues related to llvmPackages, clangStdenv and related 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Build failure: llvmPackages_git.lldb

2 participants

@wegank @rrbutani