[staging-next] python311Packages.levenshtein: fetch submodules#283726
[staging-next] python311Packages.levenshtein: fetch submodules#283726vcunat merged 1 commit intoNixOS:staging-nextfrom
Conversation
This allows access to the vendored dependency `rapidfuzz-cpp`, which is older (2.0.0) than the nixpkgs version (3.0.0). The nixpkgs `rapidfuzz-cpp` is kept in buildInputs, which enables us to seamlessly switch back to it when levenshtein catches up in the future.
I probably wouldn't do that, at least not this way. But let's hear feedback from others. |
Indeed, this seems a bit flaky (no pun intended), but upstream has a nice logic to detect system supplied dependencies and only uses vendored ones if they are not found: https://github.com/rapidfuzz/Levenshtein/blob/main/CMakeLists.txt find_package(rapidfuzz 2.0.0 QUIET)
if (rapidfuzz_FOUND)
message(STATUS "Using system supplied version of rapidfuzz-cpp")
else()
message(STATUS "Using packaged version of rapidfuzz-cpp")
add_subdirectory(extern/rapidfuzz-cpp)
endif()So I guess it would be okay, this time? I'll also wait for feedbacks and change accordingly. |
|
Let me merge this PR as is, so that the build is fixed at least. Further improvements can be done later. |
|
Please add |
Description of changes
Fix currently broken build @vcunat @fabaff
This allows access to the vendored dependency
rapidfuzz-cpp, which is older (2.0.0) than the nixpkgs version (3.0.0).The nixpkgs
rapidfuzz-cppis kept in buildInputs, which enables us to seamlessly switch back to it when levenshtein catches up in the future.Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.