[staging-next] python311Packages.scikit-learn: 1.3.2 -> 1.4.0#283666
Merged
vcunat merged 1 commit intoNixOS:staging-nextfrom Jan 25, 2024
Merged
[staging-next] python311Packages.scikit-learn: 1.3.2 -> 1.4.0#283666vcunat merged 1 commit intoNixOS:staging-nextfrom
vcunat merged 1 commit intoNixOS:staging-nextfrom
Conversation
Fix pytest failure: https://hydra.nixos.org/build/247211840/nixlog/1 See upstream PR 27628 for details. Changelog: https://scikit-learn.org/stable/whats_new/v1.4.html
2c2e7c2 to
6882fc4
Compare
13 tasks
Member
|
Sounds OK to me, though I don't know this package in particular. The ChangeLog shows lots of API changes, but I think that's relatively common for python packages. |
Member
Author
|
I also do not understand the full repercussions of this version bump... Maybe some python expert should take a look? 😉 I failed to nixpkgs-review it as the change seems to be too large for my laptop... Update: I went through the changelog and the number of API changes is terrifying. I am okay for this to be closed if we decided that it is too soon for a version bump. One can simply disable the @ofborg eval |
Member
|
Let me merge this PR as is, so that the build is fixed at least. Further improvements can be done later. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Fix pytest failure: https://hydra.nixos.org/build/247211840/nixlog/1 since: #282506.
This may or may not fix many downstream packages in staging-next.
See upstream scikit-learn/scikit-learn#27628 for details.
Changelog: https://scikit-learn.org/stable/whats_new/v1.4.html
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.