Skip to content

gtt: init at 8#282706

Merged
kirillrdy merged 1 commit intoNixOS:masterfrom
linuxissuper:add-package/gtt
Jan 23, 2024
Merged

gtt: init at 8#282706
kirillrdy merged 1 commit intoNixOS:masterfrom
linuxissuper:add-package/gtt

Conversation

@linuxissuper
Copy link
Copy Markdown
Contributor

@linuxissuper linuxissuper commented Jan 21, 2024

Description of changes

add gtt: Google Translate TUI (Originally). Now support Apertium, Argos, Bing, ChatGPT, DeepL, Google, Reverso.
from https://github.com/eeeXun/gtt

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Jan 21, 2024
@kirillrdy
Copy link
Copy Markdown
Member

@linuxissuper can you also update PR title

@linuxissuper linuxissuper changed the title Add package/gtt Add package gtt Jan 22, 2024
@kirillrdy
Copy link
Copy Markdown
Member

@linuxissuper sorry I wasn't clear enough, PR title should be gtt: init at 8

@linuxissuper linuxissuper changed the title Add package gtt gtt: init at 8 Jan 22, 2024
@linuxissuper
Copy link
Copy Markdown
Contributor Author

@linuxissuper sorry I wasn't clear enough, PR title should be gtt: init at 8

I'm sorry, should've been obvious to me 🙈
not sure why the title wasn't the first commit anyway 🤔

Copy link
Copy Markdown
Member

@AndersonTorres AndersonTorres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@delroth delroth added the 12.approvals: 1 This PR was reviewed and approved by one person. label Jan 23, 2024
@kirillrdy kirillrdy merged commit 69edbe1 into NixOS:master Jan 23, 2024
@linuxissuper linuxissuper deleted the add-package/gtt branch January 24, 2024 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants