Skip to content

killerbee: init at 3.0.0-beta.2#282429

Merged
fabaff merged 2 commits intoNixOS:masterfrom
fabaff:killerbee
Feb 19, 2024
Merged

killerbee: init at 3.0.0-beta.2#282429
fabaff merged 2 commits intoNixOS:masterfrom
fabaff:killerbee

Conversation

@fabaff
Copy link
Member

@fabaff fabaff commented Jan 20, 2024 •
edited
Loading

Description of changes

IEEE 802.15.4/ZigBee Security Research Toolkit

https://github.com/riverloopsec/killerbee

Related to #81418

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Jan 20, 2024
@fabaff fabaff mentioned this pull request Jan 20, 2024
Open
@fabaff
Copy link
Member Author

fabaff commented Jan 20, 2024

Result of nixpkgs-review pr 282429 run on x86_64-linux 1

6 packages built:
  • killerbee
  • killerbee.dist
  • python311Packages.rangeparser
  • python311Packages.rangeparser.dist
  • python312Packages.rangeparser
  • python312Packages.rangeparser.dist

@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Jan 21, 2024
@AkechiShiro
Copy link
Contributor

AkechiShiro commented Jan 21, 2024

I believe you should use the finalAttrs pattern here instead of the rec.

Let me share a couple of useful links regarding this:

History: https://discourse.nixos.org/t/avoid-rec-expresions-in-nixpkgs/8293

Documentation: https://nixos.org/manual/nixpkgs/unstable/#mkderivation-recursive-attributes

Recent example of implementation: https://github.com/NixOS/nixpkgs/compare/17f96f7b978e61576cfe16136eb418f74fab9952..9e6ea843e473d34d4f379b8b0d8ef0425a06defe

@fabaff
Copy link
Member Author

fabaff commented Feb 19, 2024

I believe you should use the finalAttrs pattern here instead of the rec.

Last time I check finalAttrs didn't play nice with python3.pkgs.buildPythonApplication. I will keep an eye on this and update later.

@fabaff fabaff merged commit 13d86d1 into NixOS:master Feb 19, 2024
@fabaff fabaff deleted the killerbee branch February 19, 2024 22:55
@github-actions
Copy link
Contributor

github-actions bot commented Feb 19, 2024

Successfully created backport PR for release-23.11:

@github-actions github-actions bot mentioned this pull request Feb 19, 2024
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

6.topic: python Python is a high-level, general-purpose programming language. 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@fabaff @AkechiShiro @D3vil0p3r