ssl-proxy: unpin go#282237
Merged
Merged
Conversation
kirillrdy
approved these changes
Jan 22, 2024
kirillrdy
left a comment
Member
There was a problem hiding this comment.
I have attempted this before, didn't get this far :-)
konst-aa
approved these changes
Jan 26, 2024
| } else { | ||
| req.URL.RawQuery = targetQuery + "&" + req.URL.RawQuery | ||
| } | ||
| - if _, ok := req.Header["User-Agent"]; !ok { |
Member
There was a problem hiding this comment.
TIL about patches. I am going to put up a PR upstream, then :-)
Member
There was a problem hiding this comment.
@marsam No luck in ~48 hours, and I also sent an email. We can wait longer, or perhaps we can merge right now, and I can put up a PR removing the patch if it gets fixed upstream.
Contributor
Author
There was a problem hiding this comment.
Yes. Thanks a lot for pushing it to upstream.
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
In order to remove Go 1.19, which has reached EOL
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.