openrct2: 0.4.5 -> 0.4.7#280741
Merged
Merged
Conversation
- https://github.com/OpenRCT2/OpenRCT2/releases/tag/v0.4.6 - https://github.com/OpenRCT2/OpenRCT2/releases/tag/v0.4.7 Updating to 0.4.6 resulted some headaches, as suddenly lots of errors about missing music objects were thrown and old maps were not loadable. This was also mentioned in NixOS#263025. Today I git bisect'ed OpenRCT2's source between 0.4.5 and 0.4.6, finding 5adbea9ac829b76507543e4c09b2000138ffbbcf as the culprit, which origins in OpenRCT2/OpenRCT2#19785. From there I got to OpenRCT2/OpenRCT2#21043 which addresses this very issue and fixes it by undoing the original change next to some later changes. This PR is now included as a patch and, et voilà, OpenRCT2 works again! Closes NixOS#263025.
NickCao
approved these changes
Jan 14, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Updating to 0.4.6 resulted some headaches, as suddenly lots of errors about missing music objects were thrown and old maps were not loadable. This was also mentioned in #263025.
Today I git bisect'ed OpenRCT2's source between 0.4.5 and 0.4.6, finding 5adbea9ac829b76507543e4c09b2000138ffbbcf as the culprit, which origins in OpenRCT2/OpenRCT2#19785. From there I got to OpenRCT2/OpenRCT2#21043 which addresses this very issue and fixes it by undoing the original change next to some later changes. This PR is now included as a patch and, et voilà, OpenRCT2 works again!
Closes #263025.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.