xsimd: disable on PowerPC (no Altivec, build fails)#279475
Closed
Conversation
added 3 commits
January 7, 2024 15:27
xsimd does not support PowerPC SIMD primitives (Altivec). Also, the build fails badly on PowerPC.
doronbehar
reviewed
Jan 21, 2024
Contributor
doronbehar
left a comment
There was a problem hiding this comment.
Looks good overall! Next time, when you make changes that affect platforms not supported by hydra, cc maintainers manually, as ofborg won't do it for you (I ran into this PR by chance).
| license = licenses.bsd3; | ||
| maintainers = with maintainers; [ tobim ]; | ||
| platforms = platforms.all; | ||
| badPlatforms = [ lib.systems.inspect.patterns.isPower ]; # no AltiVec support, build fails |
Contributor
There was a problem hiding this comment.
It shouldn't necessarily block this PR, but is upstream aware of this issue? Could we put a link here perhaps?
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
xsimd does not support PowerPC SIMD primitives (Altivec). Also, the build fails badly on PowerPC. This commit adds
isPowertometa.badPlatformsand then useslib.availableOnto omitxsimdas a dependency from builds ofscipyandpythran.This PR is necessary in order to build anything downstream of
scipyon powerpc64le.Things done