Skip to content

python311Packages.requests-download: rename from requests_download#279380

Merged
Stunkymonkey merged 1 commit intoNixOS:masterfrom
Stunkymonkey:requests-download-normalize
Jan 22, 2024
Merged

python311Packages.requests-download: rename from requests_download#279380
Stunkymonkey merged 1 commit intoNixOS:masterfrom
Stunkymonkey:requests-download-normalize

Conversation

@Stunkymonkey
Copy link
Copy Markdown
Contributor

@Stunkymonkey Stunkymonkey commented Jan 7, 2024 •
edited
Loading

Description of changes

part of #245383

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Jan 7, 2024
@Stunkymonkey Stunkymonkey mentioned this pull request Jan 7, 2024
Closed
@ofborg ofborg bot added 8.has: clean-up This PR removes packages or removes other cruft 8.has: package (new) This PR adds a new package labels Jan 7, 2024
@ofborg ofborg bot requested a review from FRidh January 7, 2024 16:18
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Jan 7, 2024
@Stunkymonkey
Copy link
Copy Markdown
Contributor Author

Stunkymonkey commented Jan 7, 2024

Result of nixpkgs-review pr 279380 run on x86_64-linux 1

4 packages built:
  • python310Packages.requests-download
  • python310Packages.requests-download.dist
  • python311Packages.requests-download
  • python311Packages.requests-download.dist

@Stunkymonkey Stunkymonkey marked this pull request as ready for review January 7, 2024 16:29
@delroth delroth added the 12.approvals: 1 This PR was reviewed and approved by one person. label Jan 22, 2024
@Stunkymonkey Stunkymonkey force-pushed the requests-download-normalize branch from 35b3387 to 5a3295a Compare January 22, 2024 23:07
@Stunkymonkey
Copy link
Copy Markdown
Contributor Author

Stunkymonkey commented Jan 22, 2024

had to rebase because of conflict in pkgs/top-level/python-aliases.nix

jfly
jfly reviewed Jan 22, 2024
View reviewed changes
@Stunkymonkey Stunkymonkey merged commit 5e05ea5 into NixOS:master Jan 22, 2024
@Stunkymonkey Stunkymonkey deleted the requests-download-normalize branch January 22, 2024 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@mweinelt mweinelt Awaiting requested review from mweinelt

@fabaff fabaff Awaiting requested review from fabaff

1 more reviewer

@jfly jfly jfly approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

6.topic: python Python is a high-level, general-purpose programming language. 8.has: clean-up This PR removes packages or removes other cruft 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Stunkymonkey @jfly @delroth