python311Packages.wxpython: rename from wxPython_4_2#279359
Merged
mweinelt merged 1 commit intoNixOS:masterfrom Jan 7, 2024
Merged
python311Packages.wxpython: rename from wxPython_4_2#279359mweinelt merged 1 commit intoNixOS:masterfrom
mweinelt merged 1 commit intoNixOS:masterfrom
Conversation
Member
|
We used to mave multiple versions in parallel, I'm not sure if that was due to lazyness or for compat reasons. I'm okay with |
Contributor
Author
|
my idea was to keep the "latest" package always named I am fine with both, the hard part is to make the decision here... Please let me know if I should change it. |
wegank
approved these changes
Jan 7, 2024
Member
wegank
left a comment
There was a problem hiding this comment.
LGTM. At some point, wxGTK32 should also be renamed to wxwidgets(_3_2), but this can be done later.
jfly
approved these changes
Jan 7, 2024
pkgs/top-level/python-aliases.nix
Outdated
Contributor
There was a problem hiding this comment.
Should there be an alias for wxPython_4_2 as well?
Contributor
Author
There was a problem hiding this comment.
you are perfectly right. fixed it.
d36b657 to
7bc5606
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
part of #245383
@mweinelt is renaming to
wxpythoncorrect? I am not sure about this.Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.