Skip to content

python311Packages.thumborPexif: remove#279356

Merged
mweinelt merged 1 commit intoNixOS:masterfrom
Stunkymonkey:thumbor-pexif-normalize
Jan 7, 2024
Merged

python311Packages.thumborPexif: remove#279356
mweinelt merged 1 commit intoNixOS:masterfrom
Stunkymonkey:thumbor-pexif-normalize

Conversation

@Stunkymonkey
Copy link
Copy Markdown
Contributor

@Stunkymonkey Stunkymonkey commented Jan 7, 2024

Description of changes

part of #245383

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Jan 7, 2024
@Stunkymonkey
Copy link
Copy Markdown
Contributor Author

Result of nixpkgs-review pr 279356 run on x86_64-linux 1

@Stunkymonkey Stunkymonkey requested a review from mweinelt January 7, 2024 12:30
@Stunkymonkey Stunkymonkey marked this pull request as ready for review January 7, 2024 12:30
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Jan 7, 2024
@mweinelt
Copy link
Copy Markdown
Member

mweinelt commented Jan 7, 2024

Please remove this package instead. It is only compatible with Python 2, and not referenced by anything in-tree.

@Stunkymonkey Stunkymonkey force-pushed the thumbor-pexif-normalize branch from 46de134 to 9c26250 Compare January 7, 2024 15:37
@Stunkymonkey Stunkymonkey changed the title python311Packages.thumbor-pexif: rename from thumborPexif python311Packages.thumborPexif: remove unused Jan 7, 2024
@mweinelt
Copy link
Copy Markdown
Member

mweinelt commented Jan 7, 2024

Per the contributing guidelines, the commit message should hold the motivation.

It is only compatible with Python 2, and not referenced by anything in-tree.
@Stunkymonkey Stunkymonkey force-pushed the thumbor-pexif-normalize branch from 9c26250 to 072000e Compare January 7, 2024 15:53
@Stunkymonkey Stunkymonkey changed the title python311Packages.thumborPexif: remove unused python311Packages.thumborPexif: remove Jan 7, 2024
@mweinelt mweinelt merged commit 255ec95 into NixOS:master Jan 7, 2024
@Stunkymonkey Stunkymonkey deleted the thumbor-pexif-normalize branch June 2, 2025 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants