Skip to content

python311Packages.dvc: fix hash#279231

Merged
fabaff merged 1 commit intoNixOS:masterfrom
Stunkymonkey:dvc-fix-checksum
Jan 6, 2024
Merged

python311Packages.dvc: fix hash#279231
fabaff merged 1 commit intoNixOS:masterfrom
Stunkymonkey:dvc-fix-checksum

Conversation

@Stunkymonkey
Copy link
Copy Markdown
Contributor

@Stunkymonkey Stunkymonkey commented Jan 6, 2024

Description of changes

does not build for me.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Jan 6, 2024
@Stunkymonkey Stunkymonkey changed the title python311Packages.dvc: fix checksum python311Packages.dvc: fix hash Jan 6, 2024
@Stunkymonkey
Copy link
Copy Markdown
Contributor Author

Result of nixpkgs-review pr 279231 run on x86_64-linux 1

10 packages built:
  • dvc (python311Packages.dvc)
  • dvc-with-remotes
  • dvc-with-remotes.dist
  • dvc.dist (python311Packages.dvc.dist)
  • python310Packages.dvc
  • python310Packages.dvc.dist
  • python310Packages.dvclive
  • python310Packages.dvclive.dist
  • python311Packages.dvclive
  • python311Packages.dvclive.dist

@Stunkymonkey Stunkymonkey requested a review from fabaff January 6, 2024 20:57
@Stunkymonkey Stunkymonkey marked this pull request as ready for review January 6, 2024 20:57
@ofborg ofborg bot requested a review from CMCDragonkai January 6, 2024 21:51
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Jan 6, 2024
@fabaff
Copy link
Copy Markdown
Member

fabaff commented Jan 6, 2024

does not build for me.

This happened in the past once or twice. We assume that the hash changes due to re-tagging.

Copy link
Copy Markdown
Member

@fabaff fabaff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good to me.

@fabaff fabaff merged commit 06b70f4 into NixOS:master Jan 6, 2024
@Stunkymonkey Stunkymonkey deleted the dvc-fix-checksum branch January 17, 2024 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants