klocalizer: init at 4.5.1#278970
Closed
Conversation
AndersonTorres
suggested changes
Jan 5, 2024
| requests | ||
| ]; | ||
|
|
||
| meta = { |
Member
There was a problem hiding this comment.
- Why not the typical ASCIIbetical ordering?
- Add changelog at https://github.com/paulgazz/kmax/releases/tag/v${version}
| }: | ||
|
|
||
| let | ||
| version = "4.5.1"; |
Member
There was a problem hiding this comment.
Personal nit: I like to let-block pname, version and src.
It is useful because changelog usually points to src.rev.
Co-authored-by: Anderson Torres <torres.anderson.85@protonmail.com>
Co-authored-by: Anderson Torres <torres.anderson.85@protonmail.com>
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
New package. This contains glue logic to be able to issue z3 (SAT/SMT solver) queries against the Linux Kconfig option database.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)