Skip to content

cosmic-files: init at unstable-2024-01-12#278745

Merged
wegank merged 1 commit intoNixOS:masterfrom
ahoneybun:init-cosmic-files
Jan 12, 2024
Merged

cosmic-files: init at unstable-2024-01-12#278745
wegank merged 1 commit intoNixOS:masterfrom
ahoneybun:init-cosmic-files

Conversation

@ahoneybun
Copy link
Copy Markdown
Contributor

@ahoneybun ahoneybun commented Jan 4, 2024

Description of changes

This adds cosmic-files to unstable.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ahoneybun ahoneybun marked this pull request as ready for review January 4, 2024 18:50
@ofborg ofborg bot added the 8.has: package (new) This PR adds a new package label Jan 4, 2024
@ofborg ofborg bot requested a review from nyabinary January 4, 2024 19:14
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Jan 4, 2024
Copy link
Copy Markdown
Member

@nbdd0121 nbdd0121 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works well.

@ahoneybun ahoneybun requested a review from nbdd0121 January 5, 2024 13:32
@Jingles52
Copy link
Copy Markdown
Contributor

working fine on hyprland for me

@delroth delroth added the 12.approvals: 1 This PR was reviewed and approved by one person. label Jan 7, 2024
@ahoneybun ahoneybun requested a review from nbdd0121 January 11, 2024 14:05
@delroth delroth removed the 12.approvals: 1 This PR was reviewed and approved by one person. label Jan 11, 2024
Copy link
Copy Markdown
Contributor

@dunxen dunxen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Result of nixpkgs-review pr 278745 run on x86_64-linux 1

1 package built: cosmic-files

Runs great on hyprland!

@delroth delroth added 12.approvals: 2 This PR was reviewed and approved by two persons. and removed 12.approvals: 2 This PR was reviewed and approved by two persons. labels Jan 12, 2024
@ahoneybun ahoneybun changed the title cosmic-files: init at unstable-2024-01-04 cosmic-files: init at unstable-2024-01-12 Jan 12, 2024
@wegank wegank merged commit ab59beb into NixOS:master Jan 12, 2024
@ahoneybun ahoneybun deleted the init-cosmic-files branch January 19, 2024 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants