haskellPackages.postgrest: 10.1.1 -> 12.0.2 and fix build#275614
haskellPackages.postgrest: 10.1.1 -> 12.0.2 and fix build#275614maralorn merged 4 commits intoNixOS:haskell-updatesfrom
Conversation
924bfbe to
5c0167d
Compare
Yes, the haskellPackages set in nixpkgs is derived primarily from stackage. In PR #272097, the stackage version is updated to LTS 21.23. For reasons of compatibility with other packages and/or ghc-9.4, the Stackage version of hasql-pool is kept down at 0.9.0.1. The latest Hackage release of hasql-pool is also available to nixpkgs, for cases like postgrest. See this note in |
|
I notice there's a v12.0.2 now. I made a PR SFrijters#3 to update. It builds but I haven't tested it apart from running |
6514aec to
158ff8c
Compare
|
Rebased on latest |
|
Maybe the nixos test is overkill; I noticed that postgrest has some Nix infrastructure so maybe we can override our checkPhase to call something from https://github.com/PostgREST/postgrest/tree/main/nix#testing ? |
|
The nixos test would be overkill, unless it's for testing a postgrest nixos module. I would be inclined to say that running the postgrest haskell package tests is more trouble than it's worth. But perhaps there are a subset of tests which don't need a postgresql server. In that case you could set The authors of postgrest may have some suggestions about what could be put in the checkPhase of this package. |
158ff8c to
0cd1da5
Compare
|
Ok, dropped the nixosTest commit for now. I'll keep it around on a branch to test any later updates manually. |
|
Thank you so much for doing this work! |
rvl
left a comment
There was a problem hiding this comment.
LGTM, thanks.
You will probably need to regenerate hackage-packages.nix after rebasing to avoid de-syncing and/or merge conflicts.
0cd1da5 to
4409608
Compare
|
Rebased, added completion, ran |
maralorn
left a comment
There was a problem hiding this comment.
Sorry for only coming back to this now. It was a busy … year.
This PR already looks very good, thank you! Still, I have a few improvement suggestions.
pkgs/development/haskell-modules/configuration-hackage2nix/main.yaml
Outdated
Show resolved
Hide resolved
4409608 to
1c17b93
Compare
1c17b93 to
111c8d7
Compare
|
Addressed review comments (I hope), rebased on latest haskell-updates. |
|
Thank you! Exzellent! |
Description of changes
Fixes #271868.
@maralorn : First attempt at fixing, please advise on improvements.
One issue that confused/surprised me is that the default
hasql-poolpackage is the 0.9 version, while the newer 0.10 version that is on Hackage ishasql-pool_0_10. Does the stackage override take precedence?Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.