Skip to content

pkgs/anki: add qtsvg to inputs to fix anki theme#273566

Merged
Mindavi merged 1 commit intoNixOS:masterfrom
euank:anki-svg
Dec 11, 2023
Merged

pkgs/anki: add qtsvg to inputs to fix anki theme#273566
Mindavi merged 1 commit intoNixOS:masterfrom
euank:anki-svg

Conversation

@euank
Copy link
Copy Markdown
Member

@euank euank commented Dec 11, 2023

Description of changes

This fixes #248357

It turns out the checkmark and so on are svg images, and without qtsvg, they don't render right, making the preferences panel appear broken.

This seems to fix it for me!

Shoutout to antecrescent for the fix! #248357 (comment)

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

This fixes NixOS#248357

It turns out the checkmark and so on are svg images, and without qtsvg,
they don't render right, making the preferences panel appear broken.

This seems to fix it for me!

Shoutout to antecrescent for the fix! NixOS#248357 (comment)
@ofborg ofborg bot requested review from oxij and paveloom December 11, 2023 18:18
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Dec 11, 2023
@delroth delroth added 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. labels Dec 11, 2023
@Mindavi Mindavi merged commit 8517f47 into NixOS:master Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

anki: UI controls in the "preferences" pages are broken

4 participants