lib/modules: Test optionless module errors from #131205#272709
Merged
Ma27 merged 2 commits intoNixOS:masterfrom Dec 10, 2023
Merged
lib/modules: Test optionless module errors from #131205#272709Ma27 merged 2 commits intoNixOS:masterfrom
Ma27 merged 2 commits intoNixOS:masterfrom
Conversation
Member
|
23d79db to
835026f
Compare
Member
Author
|
That's hilarious. I've added the test files. EDIT: and fixed the trailing newlines after configuring vscode |
835026f to
325545a
Compare
Ma27
reviewed
Dec 9, 2023
Member
There was a problem hiding this comment.
I'm so happy that past me introduced this error message because when I first looked at the code here I wondered what was wrong with this expression ;-)
Member
Author
There was a problem hiding this comment.
Yeah it doesn't look bad!
Ma27
approved these changes
Dec 9, 2023
Member
Ma27
left a comment
There was a problem hiding this comment.
One minor suggestion, but other than that LGTM and thanks a lot! :)
a063a15 to
56208ec
Compare
56208ec to
afb1a2e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Add tests for #131205.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.