nix: set enableParallelChecking = false#272438
Closed
Conversation
tests/gc-auto.sh.test and others fail nondeterministically. This is extremely frustrating for doing development on `staging` where every PR has to rebuild `nix`.
RaitoBezarius
approved these changes
Dec 6, 2023
Member
RaitoBezarius
left a comment
There was a problem hiding this comment.
I agree with the fix, I think it's important to nail down the source of nondeterminism so that the Nix core team can work on this on their pace and fix it maybe.
Author
|
Failed build: |
Author
|
Note: I do not think this is a concurrency bug in Nix -- I think it's likely a concurrency bug in the test apparatus. I'm fine with passing along this info to upstream, but in general I think that having our tests be deterministic is more important than helping upstream troubleshoot concurrency bugs in their test suite. If there were any sign that this was a concurrency bug in Nix itself (there is not) that would be a different story. If a test is specifically designed to test concurrency (like the Frankly our |
SuperSandro2000
approved these changes
Dec 6, 2023
Member
|
I assume the time difference is acceptable and not way to the moon. |
Member
|
I feel we should still open an issue upstream. |
Member
|
Thanks for the ping!
We use distinct local stores in each test ( You may still merge this if you want to test my theory. If it succeeds consistently, then that might suggest the existence of some shared state not covered by
Please do. |
Member
|
@amjoseph-nixpkgs poke - were you able to see the test flakyness with all Nix versions, or only 2.3? IIRC, there's been some stability improvements in the test suite, and some got backported to 2.3.17 (by @Ericson2314). Would help to know if this still applies to the master branch, or if 2.3 is only missing some stability backports (and in that case, |
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tests/gc-auto.sh.testand others fail nondeterministically. This is extremely frustrating for doing development onstagingwhere every PR has to rebuildnix. This is not worth whatever minor speedup we get from the parallel checks.