Skip to content

ct/tasks.nix: revert migration hack, invoke lib/tests/release.nix from single CT entry point#271819

Closed
ghost wants to merge 6 commits intomasterfrom
unknown repository
Closed

ct/tasks.nix: revert migration hack, invoke lib/tests/release.nix from single CT entry point#271819
ghost wants to merge 6 commits intomasterfrom
unknown repository

Conversation

@ghost
Copy link
Copy Markdown

@ghost ghost commented Dec 3, 2023

Please do not merge this until OfBorg has merged and deployed the following PR:

Adam Joseph added 4 commits December 2, 2023 22:12
This commit adds <nixpkgs/ct>, a single entry point for all
Continuous Testing (CT) runners, whether they are github, gerrit,
ofborg, or something else.

After merging this commit to create <nixpkgs/ct>, we will gradually
migrate the existing CT runners so that they use this interface and
*only* this interface.  This will ensure that all CT actions can be
reproduced locally by individual developers without needing access
to special infrastructure.
Ofborg is out-of-repo and has a much smaller (and therefore less
responsive) committer team.

Since it takes a long time to get them to merge and redeploy, this
commit adds a TEMPORARY call from lib/tests/release.nix to the
top-level ct entry point.

This commit should be reverted as soon as ofborg merges and deploys
the following PR, which will cause it to invoke the entry point
directly:

  #269356
Adam Joseph added 2 commits December 2, 2023 22:26
This test checks that what release-attrpaths-superset.nix calculates
is in fact a superset of the attributes which are calculated by the
much-slower ofborg method.

To run the test, invoke this command:

  nix-build pkgs/test/release/release-attrpaths-superset.nix -A failures

The result should be the empty list [].
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Dec 3, 2023
@ghost ghost closed this Jan 23, 2024
@ghost ghost deleted the ct-migration branch January 23, 2024 06:44
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: policy discussion Discuss policies to work in and around Nixpkgs 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants