Skip to content

android-studio-for-platform: init at 2023.1.1.19#269108

Closed
robbins wants to merge 1 commit intoNixOS:masterfrom
robbins:android-studio-for-platform
Closed

android-studio-for-platform: init at 2023.1.1.19#269108
robbins wants to merge 1 commit intoNixOS:masterfrom
robbins:android-studio-for-platform

Conversation

@robbins
Copy link
Copy Markdown
Contributor

@robbins robbins commented Nov 22, 2023

Description of changes

android-studio-for-platform is a variant of the Android Studio IDE designed specifically for working on AOSP.

https://developer.android.com/studio/platform

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Priorities

Add a 👍 reaction to pull requests you find important.

@robbins
Copy link
Copy Markdown
Contributor Author

robbins commented Nov 22, 2023 •
edited
Loading

Tested with a local checkout of LineageOS 20 and functionality like adding subprojects and code autocomplete work correctly.

However, during a Soong sync I am seeing these errors:

prebuilts/clang/host/linux-x86/clang-r450784d/bin/clang++.real: error while loading shared libraries: libz.so.1: cannot open shared object file: No such file or directory

FAILED: out/soong/.intermediates/frameworks/base/tests/CanvasCompare/CanvasCompare-rscript/gen/CanvasCompare.res.zip out/soong/.intermediates/frameworks/base/tests/CanvasCompare/CanvasCompare-rscript/gen/CanvasCompare.srcjar
out/host/linux-x86/bin/sbox --sandbox-path out/soong/.temp --output-dir out/soong/.intermediates/frameworks/base/tests/CanvasCompare/CanvasCompare-rscript/gen --manifest out/soong/.intermediates/frameworks/base/tests/CanvasCompare/CanvasCompare-rscript/genrule.sbox.textproto
The failing command was run inside an sbox sandbox in temporary directory
out/soong/.temp/sbox/c7603a3277e04d500de513a7e486813cf2376486
The failing command line can be found in
out/soong/.temp/sbox/c7603a3277e04d500de513a7e486813cf2376486/sbox_command.0.bash
out/soong/.temp/sbox/c7603a3277e04d500de513a7e486813cf2376486/tools/out/bin/llvm-rs-cc: error while loading shared libraries: libncurses.so.5: cannot open shared object file: No such file or directory

Adding zlib.dev and ncurses5.dev to the LD_LIBRARY_PATH section did not fix the issue.

It's possible that running ASfP inside a FHS shell such as https://nixos.wiki/wiki/Android#Building_Android_on_NixOS should successfully provide these dependencies, however I didn't test that yet. I'm also unsure, since it's essentially a compilation dependency, if we should try to provide these in the standalone ASfP derivation or if the assumption is that this will always be run from inside a shell like the one linked above that provides all compilation dependencies needed.

I guess this question also applies to the 4 Soong dependencies already added as well.

@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Nov 22, 2023
@robbins robbins closed this by deleting the head repository Jan 2, 2024
@robbins robbins mentioned this pull request Jan 2, 2024
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@robbins